[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #24524: Support unix domain socket

["TeslaCN (via GitHub)" <gi...@apache.org>]

TeslaCN commented on code in PR #24524:
URL: https://github.com/apache/shardingsphere/pull/24524#discussion_r1131889544


##########
proxy/bootstrap/src/main/java/org/apache/shardingsphere/proxy/arguments/BootstrapArguments.java:
##########
@@ -97,4 +118,13 @@ private String paddingWithSlash(final String pathArg) {
         }
         return result.toString();
     }
+    
+    private boolean isValidPath(final String path) {
+        try {
+            Paths.get(path);
+        } catch (InvalidPathException | NullPointerException ex) {
+            return false;

Review Comment:
   My understanding is that if user specified an invalid path, the socket will not be present and no error will occur. Am I right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org