You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/29 20:28:07 UTC

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6944: boards/stm32h7: add support for mcuboot

acassis commented on code in PR #6944:
URL: https://github.com/apache/incubator-nuttx/pull/6944#discussion_r957764831


##########
boards/arm/stm32h7/nucleo-h743zi/configs/netnsh/defconfig:
##########
@@ -63,6 +63,7 @@ CONFIG_RR_INTERVAL=200
 CONFIG_SCHED_HPWORK=y
 CONFIG_SCHED_LPWORK=y
 CONFIG_SCHED_WAITPID=y
+CONFIG_SDCLONE_DISABLE=y

Review Comment:
   It seems you are using old config, this option was removed:
   ```
   $ git grep SDCLONE_DISABLE
   ReleaseNotes:* [#5392](https://github.com/apache/incubator-nuttx/pull/#5392) sched: Remove SDCLONE_DISABLE option and config 
   ```



##########
boards/arm/stm32h7/nucleo-h743zi/Kconfig:
##########
@@ -27,4 +27,6 @@ config STM32_ROMFS_IMAGEFILE
 	depends on STM32_ROMFS
 	default "../../../rom.img"
 
+
+

Review Comment:
   Please remove these extra lines



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org