You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@gmail.com> on 2012/06/22 08:58:20 UTC
Review Request: FLUME-1309: Add integration tests to assembly artifacts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5516/
-----------------------------------------------------------
Review request for Flume.
Description
-------
This patch adds the integration tests to the assemblies, makes their sources sections the same / removes the old docs dir, and adds a Dummy class to the src/main/java section of the integration tests module so that the directory is not empty on the git mirror.
This addresses bug FLUME-1309.
https://issues.apache.org/jira/browse/FLUME-1309
Diffs
-----
flume-ng-dist/src/main/assembly/dist.xml 3f43ae6
flume-ng-dist/src/main/assembly/src.xml 1f82b2c
flume-ng-tests/src/main/java/org/apache/flume/Dummy.java PRE-CREATION
Diff: https://reviews.apache.org/r/5516/diff/
Testing
-------
Manual verification that mvn clean install -DskipTests is successful after unpacking artifacts.
Thanks,
Mike Percy
Re: Review Request: FLUME-1309: Add integration tests to assembly artifacts
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5516/#review8477
-----------------------------------------------------------
Ship it!
Ship It!
- Arvind Prabhakar
On June 22, 2012, 6:58 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5516/
> -----------------------------------------------------------
>
> (Updated June 22, 2012, 6:58 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> This patch adds the integration tests to the assemblies, makes their sources sections the same / removes the old docs dir, and adds a Dummy class to the src/main/java section of the integration tests module so that the directory is not empty on the git mirror.
>
>
> This addresses bug FLUME-1309.
> https://issues.apache.org/jira/browse/FLUME-1309
>
>
> Diffs
> -----
>
> flume-ng-dist/src/main/assembly/dist.xml 3f43ae6
> flume-ng-dist/src/main/assembly/src.xml 1f82b2c
> flume-ng-tests/src/main/java/org/apache/flume/Dummy.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5516/diff/
>
>
> Testing
> -------
>
> Manual verification that mvn clean install -DskipTests is successful after unpacking artifacts.
>
>
> Thanks,
>
> Mike Percy
>
>