You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Fabrice BELLINGARD (JIRA)" <ji...@codehaus.org> on 2005/11/08 17:21:06 UTC

[jira] Commented: (MNG-1038) warSourceExcludes not working properly

    [ http://jira.codehaus.org/browse/MNG-1038?page=comments#action_50334 ] 

Fabrice BELLINGARD commented on MNG-1038:
-----------------------------------------

It seems that the patch hasn't been applied yet... When will the war plugin be released with these bug fixes? It is still in beta version while most other plugins have been finalised with Maven 2.0.

> warSourceExcludes not working properly
> --------------------------------------
>
>          Key: MNG-1038
>          URL: http://jira.codehaus.org/browse/MNG-1038
>      Project: Maven 2
>         Type: Bug
>   Components: maven-war-plugin
>     Versions: 2.0-beta-1
>  Environment: Win2k, Java 1.4.2_04, m2 beta1
>     Reporter: Fabrice BELLINGARD
>     Assignee: Edwin Punzalan
>      Fix For: 2.0.1
>  Attachments: MNG-1038-maven-war-plugin.patch, MNG-1038-maven-war-plugin.patch
>
>
> Note: I posted a message on Maven users list (http://www.mail-archive.com/users%40maven.apache.org/msg24088.html), but I got no answer so I post this issue, which in turn may or not be a bug... (sorry if it's not)
> I experienced a strange behaviour with the 'warSourceExcludes' property. When I grab some Web projects from the CVS of my company, I usually get all the WEB-INF/lib Jars that the developers put in the CVS:
> - With Maven 1, I use the 'maven.war.src.excludes' property to exclude those Jars ('maven.war.src.excludes=**/lib/*.*'), and it works well: the Jars packaged in the War are only the ones defined in the pom.
> - With m2, I tried to use the 'warSourceExcludes' property, which seemed to me to be the equivalent property. However, when the War is generated, there is no jar in the WEB-INF/lib folder. This works as if the plugin is excluding files after having copied the needed dependencies in the WEB-INF/lib folder (whereas in the Maven 1 version, it was excluding them before).
> Looking at the code of the m2 plugin, the value of 'warSourceExcludes' is used in method #getExcludes which is actually called in #performPackaging method. If this property is to work the same way as in m1, its value should be used in #copyResources method, before copying the Jar dependencies in WEB-INF/lib.
> What do you guys think of that? Am I right or am I missing something?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org