You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/07/05 05:35:10 UTC
Review Request 49621: LENS-1208 : Fix join condition for outer join
of multi fact queries for expression attributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49621/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1208
https://issues.apache.org/jira/browse/LENS-1208
Repository: lens
Description
-------
Fixes join condition for outer join of multi fact queries for expression attributes
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 187d98d
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 898c438
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ea6b4a1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java d17c18f
Diff: https://reviews.apache.org/r/49621/diff/
Testing
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 399, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,183.426 sec - in TestSuite
Results :
Tests run: 399, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Amareshwari Sriramadasu
Re: Review Request 49621: LENS-1208 : Fix join condition for outer
join of multi fact queries for expression attributes
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49621/#review140724
-----------------------------------------------------------
LGTM
- Puneet Gupta
On July 5, 2016, 5:35 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49621/
> -----------------------------------------------------------
>
> (Updated July 5, 2016, 5:35 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1208
> https://issues.apache.org/jira/browse/LENS-1208
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes join condition for outer join of multi fact queries for expression attributes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 187d98d
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 898c438
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ea6b4a1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java d17c18f
>
> Diff: https://reviews.apache.org/r/49621/diff/
>
>
> Testing
> -------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Running TestSuite
> Tests run: 399, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,183.426 sec - in TestSuite
>
> Results :
>
> Tests run: 399, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 49621: LENS-1208 : Fix join condition for outer
join of multi fact queries for expression attributes
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49621/#review140736
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On July 5, 2016, 1:24 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49621/
> -----------------------------------------------------------
>
> (Updated July 5, 2016, 1:24 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1208
> https://issues.apache.org/jira/browse/LENS-1208
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fixes join condition for outer join of multi fact queries for expression attributes
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 187d98d
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 898c438
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ea6b4a1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java d17c18f
>
> Diff: https://reviews.apache.org/r/49621/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.062s]
> [INFO] Lens .............................................. SUCCESS [3.436s]
> [INFO] Lens API .......................................... SUCCESS [21.484s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.611s]
> [INFO] Lens Cube ......................................... SUCCESS [14:40.418s]
> [INFO] Lens DB storage ................................... SUCCESS [17.029s]
> [INFO] Lens Query Library ................................ SUCCESS [13.140s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:24.253s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.459s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.212s]
> [INFO] Lens Server ....................................... SUCCESS [14:09.611s]
> [INFO] Lens client ....................................... SUCCESS [1:28.842s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.297s]
> [INFO] Lens Examples ..................................... SUCCESS [8.130s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.955s]
> [INFO] Lens Distribution ................................. SUCCESS [9.071s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:11.524s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.347s]
> [INFO] Lens Regression ................................... SUCCESS [11.287s]
> [INFO] Lens UI ........................................... SUCCESS [28.069s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 37:24.123s
> [INFO] Finished at: Tue Jul 05 07:41:32 UTC 2016
> [INFO] Final Memory: 202M/2455M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 49621: LENS-1208 : Fix join condition for outer
join of multi fact queries for expression attributes
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49621/
-----------------------------------------------------------
(Updated July 5, 2016, 7:54 a.m.)
Review request for lens.
Bugs: LENS-1208
https://issues.apache.org/jira/browse/LENS-1208
Repository: lens
Description
-------
Fixes join condition for outer join of multi fact queries for expression attributes
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 187d98d
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 898c438
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ea6b4a1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java d17c18f
Diff: https://reviews.apache.org/r/49621/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.062s]
[INFO] Lens .............................................. SUCCESS [3.436s]
[INFO] Lens API .......................................... SUCCESS [21.484s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.611s]
[INFO] Lens Cube ......................................... SUCCESS [14:40.418s]
[INFO] Lens DB storage ................................... SUCCESS [17.029s]
[INFO] Lens Query Library ................................ SUCCESS [13.140s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:24.253s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.459s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.212s]
[INFO] Lens Server ....................................... SUCCESS [14:09.611s]
[INFO] Lens client ....................................... SUCCESS [1:28.842s]
[INFO] Lens CLI .......................................... SUCCESS [1:18.297s]
[INFO] Lens Examples ..................................... SUCCESS [8.130s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.955s]
[INFO] Lens Distribution ................................. SUCCESS [9.071s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:11.524s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.347s]
[INFO] Lens Regression ................................... SUCCESS [11.287s]
[INFO] Lens UI ........................................... SUCCESS [28.069s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37:24.123s
[INFO] Finished at: Tue Jul 05 07:41:32 UTC 2016
[INFO] Final Memory: 202M/2455M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 49621: LENS-1208 : Fix join condition for outer
join of multi fact queries for expression attributes
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49621/
-----------------------------------------------------------
(Updated July 5, 2016, 7:04 a.m.)
Review request for lens.
Changes
-------
Changed the condition for updating dimfield indices
Bugs: LENS-1208
https://issues.apache.org/jira/browse/LENS-1208
Repository: lens
Description
-------
Fixes join condition for outer join of multi fact queries for expression attributes
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 187d98d
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 898c438
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ea6b4a1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java d17c18f
Diff: https://reviews.apache.org/r/49621/diff/
Testing
-------
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 399, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,183.426 sec - in TestSuite
Results :
Tests run: 399, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Amareshwari Sriramadasu