You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "C. Michael Pilato" <cm...@collab.net> on 2012/09/10 13:56:26 UTC

Re: svn commit: r1382764 - /subversion/trunk/subversion/libsvn_subr/opt.c

Did this just break getopt_tests.py 2?

On 09/10/2012 07:37 AM, brane@apache.org wrote:
> Author: brane
> Date: Mon Sep 10 11:37:33 2012
> New Revision: 1382764
> 
> URL: http://svn.apache.org/viewvc?rev=1382764&view=rev
> Log:
> * subversion/libsvn_subr/opt.c (svn_opt__get_version_info):
>   Reformat the copyright message. The wording didn't change.
> 
> Modified:
>     subversion/trunk/subversion/libsvn_subr/opt.c
> 
> Modified: subversion/trunk/subversion/libsvn_subr/opt.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/opt.c?rev=1382764&r1=1382763&r2=1382764&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_subr/opt.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/opt.c Mon Sep 10 11:37:33 2012
> @@ -1116,9 +1116,8 @@ svn_opt__get_version_info(svn_boolean_t 
>    info->build_host = SVN_BUILD_HOST;
>    info->copyright = apr_pstrdup
>      (pool, _("Copyright (C) 2012 The Apache Software Foundation.\n"
> -             "This software consists of contributions made by many "
> -             "people; see the NOTICE\n"
> -             "file for more information.\n"
> +             "This software consists of contributions made by many people;\n"
> +             "see the NOTICE file for more information.\n"
>               "Subversion is open source software, see "
>               "http://subversion.apache.org/\n"));
>  
> 
> 


-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development


Re: svn commit: r1382764 - /subversion/trunk/subversion/libsvn_subr/opt.c

Posted by Branko Čibej <br...@wandisco.com>.
It might have. I'm still running the tests.

-- Brane

On 10.09.2012 13:56, C. Michael Pilato wrote:
> Did this just break getopt_tests.py 2?
>
> On 09/10/2012 07:37 AM, brane@apache.org wrote:
>> Author: brane
>> Date: Mon Sep 10 11:37:33 2012
>> New Revision: 1382764
>>
>> URL: http://svn.apache.org/viewvc?rev=1382764&view=rev
>> Log:
>> * subversion/libsvn_subr/opt.c (svn_opt__get_version_info):
>>   Reformat the copyright message. The wording didn't change.
>>
>> Modified:
>>     subversion/trunk/subversion/libsvn_subr/opt.c
>>
>> Modified: subversion/trunk/subversion/libsvn_subr/opt.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/opt.c?rev=1382764&r1=1382763&r2=1382764&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_subr/opt.c (original)
>> +++ subversion/trunk/subversion/libsvn_subr/opt.c Mon Sep 10 11:37:33 2012
>> @@ -1116,9 +1116,8 @@ svn_opt__get_version_info(svn_boolean_t 
>>    info->build_host = SVN_BUILD_HOST;
>>    info->copyright = apr_pstrdup
>>      (pool, _("Copyright (C) 2012 The Apache Software Foundation.\n"
>> -             "This software consists of contributions made by many "
>> -             "people; see the NOTICE\n"
>> -             "file for more information.\n"
>> +             "This software consists of contributions made by many people;\n"
>> +             "see the NOTICE file for more information.\n"
>>               "Subversion is open source software, see "
>>               "http://subversion.apache.org/\n"));
>>  
>>
>>
>


-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download


Re: svn commit: r1382764 - /subversion/trunk/subversion/libsvn_subr/opt.c

Posted by Branko Čibej <br...@wandisco.com>.
On 10.09.2012 14:04, C. Michael Pilato wrote:
> (Answering my own question...) Yes, it did.  I fixed the test expectations
> for you:
>
>    Sending        getopt_tests_data/svn--version_stdout
>    Transmitting file data .
>    Committed revision 1382782.

Thanks! I made the same change locally, but you beat me to the commit.

-- Brane

>
> On 09/10/2012 07:56 AM, C. Michael Pilato wrote:
>> Did this just break getopt_tests.py 2?
>>
>> On 09/10/2012 07:37 AM, brane@apache.org wrote:
>>> Author: brane
>>> Date: Mon Sep 10 11:37:33 2012
>>> New Revision: 1382764
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1382764&view=rev
>>> Log:
>>> * subversion/libsvn_subr/opt.c (svn_opt__get_version_info):
>>>   Reformat the copyright message. The wording didn't change.
>>>
>>> Modified:
>>>     subversion/trunk/subversion/libsvn_subr/opt.c
>>>
>>> Modified: subversion/trunk/subversion/libsvn_subr/opt.c
>>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/opt.c?rev=1382764&r1=1382763&r2=1382764&view=diff
>>> ==============================================================================
>>> --- subversion/trunk/subversion/libsvn_subr/opt.c (original)
>>> +++ subversion/trunk/subversion/libsvn_subr/opt.c Mon Sep 10 11:37:33 2012
>>> @@ -1116,9 +1116,8 @@ svn_opt__get_version_info(svn_boolean_t 
>>>    info->build_host = SVN_BUILD_HOST;
>>>    info->copyright = apr_pstrdup
>>>      (pool, _("Copyright (C) 2012 The Apache Software Foundation.\n"
>>> -             "This software consists of contributions made by many "
>>> -             "people; see the NOTICE\n"
>>> -             "file for more information.\n"
>>> +             "This software consists of contributions made by many people;\n"
>>> +             "see the NOTICE file for more information.\n"
>>>               "Subversion is open source software, see "
>>>               "http://subversion.apache.org/\n"));
>>>  
>>>
>>>
>>
>


-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download


Re: svn commit: r1382764 - /subversion/trunk/subversion/libsvn_subr/opt.c

Posted by "C. Michael Pilato" <cm...@collab.net>.
(Answering my own question...) Yes, it did.  I fixed the test expectations
for you:

   Sending        getopt_tests_data/svn--version_stdout
   Transmitting file data .
   Committed revision 1382782.

On 09/10/2012 07:56 AM, C. Michael Pilato wrote:
> Did this just break getopt_tests.py 2?
> 
> On 09/10/2012 07:37 AM, brane@apache.org wrote:
>> Author: brane
>> Date: Mon Sep 10 11:37:33 2012
>> New Revision: 1382764
>>
>> URL: http://svn.apache.org/viewvc?rev=1382764&view=rev
>> Log:
>> * subversion/libsvn_subr/opt.c (svn_opt__get_version_info):
>>   Reformat the copyright message. The wording didn't change.
>>
>> Modified:
>>     subversion/trunk/subversion/libsvn_subr/opt.c
>>
>> Modified: subversion/trunk/subversion/libsvn_subr/opt.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/opt.c?rev=1382764&r1=1382763&r2=1382764&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/libsvn_subr/opt.c (original)
>> +++ subversion/trunk/subversion/libsvn_subr/opt.c Mon Sep 10 11:37:33 2012
>> @@ -1116,9 +1116,8 @@ svn_opt__get_version_info(svn_boolean_t 
>>    info->build_host = SVN_BUILD_HOST;
>>    info->copyright = apr_pstrdup
>>      (pool, _("Copyright (C) 2012 The Apache Software Foundation.\n"
>> -             "This software consists of contributions made by many "
>> -             "people; see the NOTICE\n"
>> -             "file for more information.\n"
>> +             "This software consists of contributions made by many people;\n"
>> +             "see the NOTICE file for more information.\n"
>>               "Subversion is open source software, see "
>>               "http://subversion.apache.org/\n"));
>>  
>>
>>
> 
> 


-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development