You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/12 15:04:11 UTC
[GitHub] [shardingsphere] weihubeats opened a new pull request, #16778: DistributeLockContext.renew(final AckLockedEvent event) need add unit test
weihubeats opened a new pull request, #16778:
URL: https://github.com/apache/shardingsphere/pull/16778
Fixes #16671.
Changes proposed in this pull request:
-
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on a diff in pull request #16778: DistributeLockContext.renew(final AckLockedEvent event) need add unit test
Posted by GitBox <gi...@apache.org>.
yx9o commented on code in PR #16778:
URL: https://github.com/apache/shardingsphere/pull/16778#discussion_r850035344
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/lock/DistributeLockContextTest.java:
##########
@@ -42,7 +43,7 @@
import static org.mockito.Mockito.mock;
public final class DistributeLockContextTest {
-
+
Review Comment:
Sorry, there are still some unfinished, please check the file again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] weihubeats commented on a diff in pull request #16778: DistributeLockContext.renew(final AckLockedEvent event) need add unit test
Posted by GitBox <gi...@apache.org>.
weihubeats commented on code in PR #16778:
URL: https://github.com/apache/shardingsphere/pull/16778#discussion_r850031554
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/lock/DistributeLockContextTest.java:
##########
@@ -42,7 +43,7 @@
import static org.mockito.Mockito.mock;
public final class DistributeLockContextTest {
-
+
Review Comment:
ok processed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on a diff in pull request #16778: DistributeLockContext.renew(final AckLockedEvent event) need add unit test
Posted by GitBox <gi...@apache.org>.
yx9o commented on code in PR #16778:
URL: https://github.com/apache/shardingsphere/pull/16778#discussion_r850028648
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/lock/DistributeLockContextTest.java:
##########
@@ -42,7 +43,7 @@
import static org.mockito.Mockito.mock;
public final class DistributeLockContextTest {
-
+
Review Comment:
Please keep the indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o merged pull request #16778: DistributeLockContext.renew(final AckLockedEvent event) need add unit test
Posted by GitBox <gi...@apache.org>.
yx9o merged PR #16778:
URL: https://github.com/apache/shardingsphere/pull/16778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] weihubeats commented on a diff in pull request #16778: DistributeLockContext.renew(final AckLockedEvent event) need add unit test
Posted by GitBox <gi...@apache.org>.
weihubeats commented on code in PR #16778:
URL: https://github.com/apache/shardingsphere/pull/16778#discussion_r850049164
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-cluster-mode/shardingsphere-cluster-mode-core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/coordinator/lock/DistributeLockContextTest.java:
##########
@@ -42,7 +43,7 @@
import static org.mockito.Mockito.mock;
public final class DistributeLockContextTest {
-
+
Review Comment:
ok, you're looking, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org