You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Fox (JIRA)" <ji...@apache.org> on 2011/07/15 18:01:00 UTC
[jira] [Created] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
------------------------------------------------------------------------------------------------------------
Key: TORQUE-166
URL: https://issues.apache.org/jira/browse/TORQUE-166
Project: Torque
Issue Type: Improvement
Reporter: Thomas Fox
These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Assigned] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox reassigned TORQUE-166:
---------------------------------
Assignee: Thomas Fox
> remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
> ------------------------------------------------------------------------------------------------------------
>
> Key: TORQUE-166
> URL: https://issues.apache.org/jira/browse/TORQUE-166
> Project: Torque
> Issue Type: Improvement
> Reporter: Thomas Fox
> Assignee: Thomas Fox
>
> These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Commented] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066038#comment-13066038 ]
Thomas Fox commented on TORQUE-166:
-----------------------------------
This was discussed on the dev list, see
http://mail-archives.apache.org/mod_mbox/db-torque-dev/201105.mbox/%3COF47D897B4.2412951A-ONC125788B.00405C58-C125788B.006E22D4@seitenbau.net%3E
and followups
> remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
> ------------------------------------------------------------------------------------------------------------
>
> Key: TORQUE-166
> URL: https://issues.apache.org/jira/browse/TORQUE-166
> Project: Torque
> Issue Type: Improvement
> Reporter: Thomas Fox
> Assignee: Thomas Fox
>
> These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Resolved] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox resolved TORQUE-166.
-------------------------------
Resolution: Fixed
Fix Version/s: 4.0
The new method is called getDbObjectInstance() since the OM terminology is no longer used
> remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
> ------------------------------------------------------------------------------------------------------------
>
> Key: TORQUE-166
> URL: https://issues.apache.org/jira/browse/TORQUE-166
> Project: Torque
> Issue Type: Improvement
> Reporter: Thomas Fox
> Assignee: Thomas Fox
> Fix For: 4.0
>
>
> These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Closed] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox closed TORQUE-166.
-----------------------------
> remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
> ------------------------------------------------------------------------------------------------------------
>
> Key: TORQUE-166
> URL: https://issues.apache.org/jira/browse/TORQUE-166
> Project: Torque
> Issue Type: Improvement
> Reporter: Thomas Fox
> Assignee: Thomas Fox
> Fix For: 4.0-beta1
>
>
> These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Commented] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067047#comment-13067047 ]
Thomas Fox commented on TORQUE-166:
-----------------------------------
What about generating a getOMInstance method in the Peer returning a new OMClass() ?
In my opinion we should avoid using reflection wherever possible. Also, getOMInstance() is more flexible, one can override the method and instantiate classes which do not have a no-arg constructor.
When needed, one can still find out the OMClass by getOMInstance().getClass()
> remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
> ------------------------------------------------------------------------------------------------------------
>
> Key: TORQUE-166
> URL: https://issues.apache.org/jira/browse/TORQUE-166
> Project: Torque
> Issue Type: Improvement
> Reporter: Thomas Fox
> Assignee: Thomas Fox
>
> These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Commented] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
Posted by "CG Monroe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067042#comment-13067042 ]
CG Monroe commented on TORQUE-166:
----------------------------------
Personally, I'd like to see this remain even if we aren't using it internally.
The use case for keeping this is user written functions that take a generic Peer class as a parameter and then need to get a record object.
I found it useful in 3.x that given one of any of the main classes (e.g. Map, Peer, or OM), you can easily access the other two via methods in the class you have. Makes righting dynamic code like application specific import and export function easier.
> remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
> ------------------------------------------------------------------------------------------------------------
>
> Key: TORQUE-166
> URL: https://issues.apache.org/jira/browse/TORQUE-166
> Project: Torque
> Issue Type: Improvement
> Reporter: Thomas Fox
> Assignee: Thomas Fox
>
> These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Commented] (TORQUE-166) remove the getOMClass() method, the
CLASS_DEFAULT constant and the initClass() method in the generated peers
Posted by "CG Monroe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067063#comment-13067063 ]
CG Monroe commented on TORQUE-166:
----------------------------------
That works for me... I only care about getting access to a record class and not the underlying methodology.
Re: reflection. Agree we shouldn't use it internally but when external users are dealing with the generated code it is sometimes the only way to get things to work. May not like it but you can't ignore there is a bunch of gee whiz code out there that uses it.
> remove the getOMClass() method, the CLASS_DEFAULT constant and the initClass() method in the generated peers
> ------------------------------------------------------------------------------------------------------------
>
> Key: TORQUE-166
> URL: https://issues.apache.org/jira/browse/TORQUE-166
> Project: Torque
> Issue Type: Improvement
> Reporter: Thomas Fox
> Assignee: Thomas Fox
>
> These methods and constants were used by village and are not needed any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org