You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/04 07:33:55 UTC
[GitHub] [buildstream] BuildStream-Migration-Bot opened a new pull request #1427: Draft: utils.py: Remove the (?ms) switch at the start of _glob2re
BuildStream-Migration-Bot opened a new pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427
[See original merge request on GitLab](https://gitlab.com/BuildStream/buildstream/-/merge_requests/2047)
In GitLab by [[Gitlab user @BenjaminSchubert]](https://gitlab.com/BenjaminSchubert) on Aug 28, 2020, 15:00
The ?ms switch stands for multiline output.
This switch is used nowhere in our codebase.
It also is problematic in multiple places where its use is deprecated since python 3.7,
as now they need to be at the start of an expression, which is not the
case in all the calls to it that we are doing.
If someone wants the same functionality, they should add it explictely
after calling _glob2re
## TODO
Still need to add a test to see how BuildStream behaves with split files that have such characters in them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BenjaminSchubert commented on pull request #1427: Draft: utils.py: Remove the (?ms) switch at the start of _glob2re
Posted by GitBox <gi...@apache.org>.
BenjaminSchubert commented on pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427#issuecomment-1068489452
@juergbi @nanonyme may I get a review on that one please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1427: Draft: utils.py: Remove the (?ms) switch at the start of _glob2re
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427#issuecomment-773098577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1427: utils.py: Remove the (?ms) switch at the start of _glob2re
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427#issuecomment-1072167184
Rebased and tested this locally, let's merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1427: utils.py: Remove the (?ms) switch at the start of _glob2re
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427#issuecomment-1072167184
Rebased and tested this locally, let's merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1427: utils.py: Remove the (?ms) switch at the start of _glob2re
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1427: utils.py: Remove the (?ms) switch at the start of _glob2re
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1427: Draft: utils.py: Remove the (?ms) switch at the start of _glob2re
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1427:
URL: https://github.com/apache/buildstream/pull/1427#issuecomment-773098577
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org