You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/05 05:12:28 UTC

[GitHub] [dolphinscheduler] devosend commented on a change in pull request #8704: [Fix-8624][UI-Next][V1.0.0-Alpha] Rectify the issue to display the timing form when clicking the timing button in the process definition page.

devosend commented on a change in pull request #8704:
URL: https://github.com/apache/dolphinscheduler/pull/8704#discussion_r820043820



##########
File path: dolphinscheduler-ui-next/src/views/projects/workflow/definition/components/timing-modal.tsx
##########
@@ -188,8 +188,8 @@ export default defineComponent({
       () => props.row,
       () => {
         timingState.timingForm.startEndTime = [
-          new Date(props.row.startTime),
-          new Date(props.row.endTime)
+          props.row.startTime? new Date(props.row.startTime) : new Date(),

Review comment:
       You can use `props.row.crontab` to determine whether timeForm init is needed. Beause timeForm.crontab and other's needs to be initialized.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org