You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/12/04 23:37:59 UTC
[PR] [typo](comments) fix typo "destroy" [doris]
kaijchen opened a new pull request, #27979:
URL: https://github.com/apache/doris/pull/27979
## Proposed changes
fix typo "destory" -> "destroy"
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [typo](comments) fix typo "destroy" [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1839741910
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](typo) fix typo "destory" to "destroy" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1851170215
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit c6ecad87655e32fa9ec4ddf200ee837574776023, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4700 4472 4482 4472
q2 362 151 158 151
q3 1466 1233 1222 1222
q4 1119 889 888 888
q5 3165 3153 3157 3153
q6 245 125 129 125
q7 998 485 476 476
q8 2183 2226 2175 2175
q9 6684 6689 6632 6632
q10 3228 3237 3263 3237
q11 326 207 193 193
q12 346 201 206 201
q13 4550 3798 3777 3777
q14 246 219 216 216
q15 575 524 519 519
q16 439 386 401 386
q17 1008 591 563 563
q18 7288 6949 7136 6949
q19 1505 1264 1475 1264
q20 531 333 301 301
q21 3085 2575 2661 2575
q22 347 282 291 282
Total cold run time: 44396 ms
Total hot run time: 39757 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4391 4390 4385 4385
q2 264 160 173 160
q3 3557 3549 3546 3546
q4 2389 2381 2391 2381
q5 5764 5729 5745 5729
q6 240 121 121 121
q7 2394 1879 1863 1863
q8 3508 3533 3528 3528
q9 9011 8978 8996 8978
q10 3886 3961 3977 3961
q11 500 380 375 375
q12 766 599 611 599
q13 4330 3588 3602 3588
q14 285 258 252 252
q15 566 526 521 521
q16 495 462 470 462
q17 1870 1835 1838 1835
q18 8777 8311 8997 8311
q19 1696 1749 1772 1749
q20 2247 1938 1925 1925
q21 6563 6221 6183 6183
q22 498 427 416 416
Total cold run time: 63997 ms
Total hot run time: 60868 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](typo) fix typo "destory" to "destroy" [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #27979: [fix](typo) fix typo "destory" to "destroy"
URL: https://github.com/apache/doris/pull/27979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](typo) fix typo "destory" to "destroy" [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-2156914993
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](typo) fix typo "destory" to "destroy" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1851181219
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.51 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17221022347 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [typo](comments) fix typo "destroy" [doris]
Posted by "ruancomelli (via GitHub)" <gi...@apache.org>.
ruancomelli commented on code in PR #27979:
URL: https://github.com/apache/doris/pull/27979#discussion_r1420370855
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -553,7 +553,7 @@ void ExecEnv::destroy() {
SAFE_STOP(_external_scan_context_mgr);
SAFE_STOP(_fragment_mgr);
SAFE_STOP(_runtime_filter_timer_queue);
- // NewLoadStreamMgr should be destoried before storage_engine & after fragment_mgr stopped.
+ // NewLoadStreamMgr should be destroied before storage_engine & after fragment_mgr stopped.
Review Comment:
```suggestion
// NewLoadStreamMgr should be destroyed before storage_engine & after fragment_mgr stopped.
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -590,15 +590,15 @@ void ExecEnv::destroy() {
SAFE_DELETE(_segment_loader);
SAFE_DELETE(_row_cache);
- // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset
- // StorageEngine must be destoried before _cache_manager destory
+ // StorageEngine must be destroied before _page_no_cache_mem_tracker.reset
+ // StorageEngine must be destroied before _cache_manager destroy
Review Comment:
```suggestion
// StorageEngine must be destroyed before _page_no_cache_mem_tracker.reset
// StorageEngine must be destroyed before _cache_manager destroy
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -590,15 +590,15 @@ void ExecEnv::destroy() {
SAFE_DELETE(_segment_loader);
SAFE_DELETE(_row_cache);
- // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset
- // StorageEngine must be destoried before _cache_manager destory
+ // StorageEngine must be destroied before _page_no_cache_mem_tracker.reset
+ // StorageEngine must be destroied before _cache_manager destroy
SAFE_DELETE(_storage_engine);
// _scanner_scheduler must be desotried before _storage_page_cache
SAFE_DELETE(_scanner_scheduler);
- // _storage_page_cache must be destoried before _cache_manager
+ // _storage_page_cache must be destroied before _cache_manager
SAFE_DELETE(_storage_page_cache);
- // cache_manager must be destoried after _inverted_index_query_cache
+ // cache_manager must be destroied after _inverted_index_query_cache
Review Comment:
```suggestion
// cache_manager must be destroyed after _inverted_index_query_cache
```
##########
be/src/olap/wal_manager.cpp:
##########
@@ -45,7 +45,7 @@ WalManager::WalManager(ExecEnv* exec_env, const std::string& wal_dir_list)
}
WalManager::~WalManager() {
- LOG(INFO) << "WalManager is destoried";
+ LOG(INFO) << "WalManager is destroied";
Review Comment:
I'm afraid this is still not right... the correct spelling is `destroy`/`destroyed`:
```suggestion
LOG(INFO) << "WalManager is destroyed";
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -590,15 +590,15 @@ void ExecEnv::destroy() {
SAFE_DELETE(_segment_loader);
SAFE_DELETE(_row_cache);
- // StorageEngine must be destoried before _page_no_cache_mem_tracker.reset
- // StorageEngine must be destoried before _cache_manager destory
+ // StorageEngine must be destroied before _page_no_cache_mem_tracker.reset
+ // StorageEngine must be destroied before _cache_manager destroy
SAFE_DELETE(_storage_engine);
// _scanner_scheduler must be desotried before _storage_page_cache
SAFE_DELETE(_scanner_scheduler);
- // _storage_page_cache must be destoried before _cache_manager
+ // _storage_page_cache must be destroied before _cache_manager
Review Comment:
```suggestion
// _storage_page_cache must be destroyed before _cache_manager
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -640,7 +640,7 @@ void ExecEnv::destroy() {
_serial_download_cache_thread_token.reset(nullptr);
_download_cache_thread_pool.reset(nullptr);
- // _heartbeat_flags must be destoried after staroge engine
+ // _heartbeat_flags must be destroied after staroge engine
Review Comment:
```suggestion
// _heartbeat_flags must be destroyed after storage engine
```
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -649,7 +649,7 @@ void ExecEnv::destroy() {
// info is deconstructed then BE process will core at coordinator back method in fragment mgr.
SAFE_DELETE(_master_info);
- LOG(INFO) << "Doris exec envorinment is destoried.";
+ LOG(INFO) << "Doris exec envorinment is destroied.";
Review Comment:
```suggestion
LOG(INFO) << "Doris exec environment is destroyed.";
```
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -412,7 +412,7 @@ GroupCommitMgr::GroupCommitMgr(ExecEnv* exec_env) : _exec_env(exec_env) {
}
GroupCommitMgr::~GroupCommitMgr() {
- LOG(INFO) << "GroupCommitMgr is destoried";
+ LOG(INFO) << "GroupCommitMgr is destroied";
Review Comment:
```suggestion
LOG(INFO) << "GroupCommitMgr is destroyed";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [typo](comments) fix typo "destroy" [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1839728771
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](typo) fix typo "destory" to "destroy" [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1848091110
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [typo](comments) fix typo "destroy" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1839857299
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.37 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17167121699 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [typo](comments) fix typo "destroy" [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1848088083
@ruancomelli Thanks for the suggestions, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](typo) fix typo "destory" to "destroy" [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #27979:
URL: https://github.com/apache/doris/pull/27979#issuecomment-1851145649
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org