You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/21 01:06:55 UTC
[GitHub] [incubator-pinot] Jackie-Jiang edited a comment on issue #4214:
Support default BYTES (zero-length byte array) in aggregation function and
aggregator
Jackie-Jiang edited a comment on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator
URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-494201220
@kishoreg Without this PR, in order to create default columns for serialized Object such as HyperLogLog, TDigest etc., user needs to serialize the default Object (empty HyperLogLog or TDigest) in order to get the default value and then put it into the schema. The default values are quite long for these Objects (HyperLogLog: "00000008000000ac00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"; QDigest: "3fa999999999999a0000000000000000000000000004b9467fffffffffffffff800000000000000000000000"; TDigest: "000000017ff0000000000000fff0000000000000405900000000000000000000").
With this PR, we directly treat empty byte array as null, so user doesn't need to specify such default values.
Besides, this PR allows user to put empty byte array to skip a value which can save storage and reduce computation cost. E.g. for one record, there is not value in the HyperLogLog, user can simply put an empty array instead of the serialized byte array.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org