You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2021/07/20 04:18:11 UTC

[spark] branch branch-3.2 updated: [SPARK-36216][PYTHON][TESTS] Increase timeout for StreamingLinearRegressionWithTests. test_parameter_convergence

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.2 by this push:
     new 9d46150  [SPARK-36216][PYTHON][TESTS] Increase timeout for StreamingLinearRegressionWithTests. test_parameter_convergence
9d46150 is described below

commit 9d461501b9d2ff8cc73551756379ddd0ada1c39b
Author: Hyukjin Kwon <gu...@apache.org>
AuthorDate: Tue Jul 20 13:17:05 2021 +0900

    [SPARK-36216][PYTHON][TESTS] Increase timeout for StreamingLinearRegressionWithTests. test_parameter_convergence
    
    ### What changes were proposed in this pull request?
    
    Test is flaky (https://github.com/apache/spark/runs/3109815586):
    
    ```
    Traceback (most recent call last):
      File "/__w/spark/spark/python/pyspark/mllib/tests/test_streaming_algorithms.py", line 391, in test_parameter_convergence
        eventually(condition, catch_assertions=True)
      File "/__w/spark/spark/python/pyspark/testing/utils.py", line 91, in eventually
        raise lastValue
      File "/__w/spark/spark/python/pyspark/testing/utils.py", line 82, in eventually
        lastValue = condition()
      File "/__w/spark/spark/python/pyspark/mllib/tests/test_streaming_algorithms.py", line 387, in condition
        self.assertEqual(len(model_weights), len(batches))
    AssertionError: 9 != 10
    ```
    
    Should probably increase timeout
    
    ### Why are the changes needed?
    
    To avoid flakiness in the test.
    
    ### Does this PR introduce _any_ user-facing change?
    
    Nope, dev-only.
    
    ### How was this patch tested?
    
    CI should test it out.
    
    Closes #33427 from HyukjinKwon/SPARK-36216.
    
    Authored-by: Hyukjin Kwon <gu...@apache.org>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
    (cherry picked from commit d6b974f8ceb5383e5f01cf87a267b7580f992ac1)
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 python/pyspark/mllib/tests/test_streaming_algorithms.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/pyspark/mllib/tests/test_streaming_algorithms.py b/python/pyspark/mllib/tests/test_streaming_algorithms.py
index f6c6779..ba0c86f 100644
--- a/python/pyspark/mllib/tests/test_streaming_algorithms.py
+++ b/python/pyspark/mllib/tests/test_streaming_algorithms.py
@@ -388,7 +388,7 @@ class StreamingLinearRegressionWithTests(MLLibStreamingTestCase):
             return True
 
         # We want all batches to finish for this test.
-        eventually(condition, catch_assertions=True)
+        eventually(condition, 90, catch_assertions=True)
 
         w = array(model_weights)
         diff = w[1:] - w[:-1]

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org