You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by rdowner <gi...@git.apache.org> on 2015/07/14 22:37:07 UTC
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
GitHub user rdowner opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/746
Fix dist to have suitable name, and suitably-named directory inside
In commit 56285ad89cc2ba7b9ea540cfb0de25f411d14e29, which modifies the way that Brooklyn dist is built, @ahgittin notes: *"finalName affects name in `target/` but we cannot influence name when it is attached/installed, so `apache-` prefix would be lost there. to keep it consistent this is commented out, but would be nice to have if there is a way!"*
However I am not certain why this is an issue, and why we need to insist that the built artifact name must be consistent with the attached-artifact name. The primary concern of the distribution is a single downloadable binary archive. This archive should be named appropriately for the product, and convention dictates that the archive contains a single directory with the same name as the archive, and that directory contains all the files. maven-assembly-plugin will also upload them to the repository, but forces them to be a particular name. However, *that isn't important* - users aren't going to get the binary download by digging through Maven repositories, they are going to get it from the Apache download page. The Maven artifact of the distribution is merely a side effect, so does it really matter what its name is?
This PR changes the name of the archives to `apache-brooklyn-VERSION-bin.tar.gz` and `.zip`. Each contains a single folder, `apache-brooklyn-VERSION-bin`, which contains all the files for the distribution.
This corresponds to the release process, which is producing names and formats identical except that `bin` is substituted for `src`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rdowner/incubator-brooklyn dist-artifact-naming
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/746.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #746
----
commit 61a01dad2b7bebc79df93f7e58e434a570ef9ec5
Author: Richard Downer <ri...@apache.org>
Date: 2015-07-14T17:21:30Z
Fix dist to have suitable name, and suitably-named directory inside
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/746#issuecomment-121512708
Ok. Rather than proceeding with this and its potential complications (including breaking `BrooklynNode` again), I'm closing this PR and will instead modify the release script to post-process the dist archives to have the expected names.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/746#issuecomment-121383744
If we don't need the tar.gz artifact in the repo let's just not attach it. But if attached it'd be nice to have the same extracted folder as the file name.
One instance where it's important is `BrooklynNode` - it will download the dist from the repository by default and infer the extract folder from the download file name.
Alternatively we could have two tar.gz files - one attached with the default name and one with apache prefix which is not uploaded to the repo. This will increase the build time, so not ideal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/746#issuecomment-121569600
I believe we can iron out the release process via a series of releases.
Hadrian
On 07/15/2015 03:17 AM, Richard Downer wrote:
> Ok. Rather than proceeding with this and its potential complications
> (including breaking |BrooklynNode| again), I'm closing this PR and will
> instead modify the release script to post-process the dist archives to
> have the expected names.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-brooklyn/pull/746#issuecomment-121512708>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/746#issuecomment-121377360
Once #745 is merged, this PR will need an additional change to ensure `BrooklynNode` continues to work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/746#issuecomment-121386468
@neykov I'm perfectly happy to not attach the artifacts. I can't see many use cases that would require downloading the artifact from deep inside Nexus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/746#issuecomment-121442824
> However, that isn't important - users aren't going to get the binary download by digging through Maven repositories, they are going to get it from the Apache download page.
I wouldn't be so sure about that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix dist to have suitable name, a...
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---