You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "Steve Moist (JIRA)" <ji...@apache.org> on 2018/03/27 14:51:00 UTC
[jira] [Commented] (SENTRY-2188) 75+ files are uneccessarily
changed when generetating new Thrift files.
[ https://issues.apache.org/jira/browse/SENTRY-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415755#comment-16415755 ]
Steve Moist commented on SENTRY-2188:
-------------------------------------
So the generated thrift files are checked in. In general, generated code should go in the maven target directory under generated-sources. My proposed change is to use the thrift mvn plugin to generate the code and move the thrift code into generated sources.
> 75+ files are uneccessarily changed when generetating new Thrift files.
> -----------------------------------------------------------------------
>
> Key: SENTRY-2188
> URL: https://issues.apache.org/jira/browse/SENTRY-2188
> Project: Sentry
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.0.0
> Reporter: Steve Moist
> Assignee: Steve Moist
> Priority: Minor
>
> When modifying the thrift apis, the developer needs to regenerate the thrift model. When that happens, the thrift portion of the build unnecessarily touches 75+ generated thrift files with a new timestamp. No actual code or bindings is affected. From a developer perspective, this is bad as the developer has to undo those changes to the 75+ files. We should modify how the thrift api's are generated so that they do not regenerate old changes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)