You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2012/10/28 23:33:12 UTC
[jira] [Created] (MATH-884) "isSymmetric" in "MatrixUtils"
Gilles created MATH-884:
---------------------------
Summary: "isSymmetric" in "MatrixUtils"
Key: MATH-884
URL: https://issues.apache.org/jira/browse/MATH-884
Project: Commons Math
Issue Type: Task
Reporter: Gilles
Assignee: Gilles
Priority: Minor
Fix For: 3.1
I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Thomas Neidhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486276#comment-13486276 ]
Thomas Neidhart commented on MATH-884:
--------------------------------------
The distinction for is/check makes sense imho. So please go ahead.
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486036#comment-13486036 ]
Phil Steitz commented on MATH-884:
----------------------------------
Sorry, I misread the code, thinking the first method was going to be public. I like the "check" / "is" setup. Looks good to go.
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles resolved MATH-884.
-------------------------
Resolution: Fixed
Committed in revision 1403587.
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-884:
------------------------
Attachment: MATH-884.diff
Attached the new code for "MatrixUtils" and "MatrixUtilsTest".
OK to apply?
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486023#comment-13486023 ]
Gilles commented on MATH-884:
-----------------------------
bq. That does not appear to be used in EigenDecomposition.
An exception is not thrown there, but the feature could be useful used as a precondition check in the "Weight" in class (package "o.a.c.m.optimization").
Or in a much needed implementation of a symmetric matrix.
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485799#comment-13485799 ]
Phil Steitz commented on MATH-884:
----------------------------------
+1 to move this, but I have one question: why do we need the "raiseException" flag? That does not appear to be used in EigenDecomposition.
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485990#comment-13485990 ]
Gilles commented on MATH-884:
-----------------------------
Supporting the raising of an exception makes it similar to other "check..." methods. (The flag is not part of the public API.)
If there is a failed precondition and an exception is raised, it is probably nice to provide the element's indices where the symmetry property is broken (the indices are arguments to this exception's constructor). This cannot be done by just calling "isSymmetric" and then raise the an exception if it returned false.
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-884) "isSymmetric" in "MatrixUtils"
Posted by "Thomas Neidhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485858#comment-13485858 ]
Thomas Neidhart commented on MATH-884:
--------------------------------------
It was only used before the addition of support for general matrices. In case of a non-symmetric matrix, an exception was raised in the ctor.
I guess it can be removed now.
> "isSymmetric" in "MatrixUtils"
> ------------------------------
>
> Key: MATH-884
> URL: https://issues.apache.org/jira/browse/MATH-884
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Fix For: 3.1
>
> Attachments: MATH-884.diff
>
>
> I propose to move the method "isSymmetric" from "EigenDecomposition" to "MatrixUtils" (package "o.a.c.m.linear").
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira