Re: [PR] GH-932: [JDBC] Fix memory leak on Connection#close due to unclosed Statement(s) [arrow-java]

["ennuite (via GitHub)" <gi...@apache.org>]

ennuite commented on code in PR #933:
URL: https://github.com/apache/arrow-java/pull/933#discussion_r2673788920


##########
flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightConnection.java:
##########


Review Comment:
   I can't build a single list of AutoCloseables because ExecutorService isn't AutoCloseable before Java 19. I built a list with the ones I could, and left the try catch logic for the rest. Is this ok?
   
   A question that hit me while doing this was what MT-safety guarantees we have on the implementation of the JDBC driver. The JDBC 4.3 spec doesn't speak about whether implementations of interfaces such as Connection need to be MT-safe, but older versions of the spec do speak about it: https://web.archive.org/web/20090213013250/http://java.sun.com/j2se/1.3/docs/guide/jdbc/spec/jdbc-spec.frame9.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org