You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by re...@apache.org on 2018/06/20 14:13:15 UTC

svn commit: r1833917 - /jackrabbit/site/trunk/src/site/markdown/creating-releases.md

Author: reschke
Date: Wed Jun 20 14:13:15 2018
New Revision: 1833917

URL: http://svn.apache.org/viewvc?rev=1833917&view=rev
Log:
add hint to check for unintended export version changes

Modified:
    jackrabbit/site/trunk/src/site/markdown/creating-releases.md

Modified: jackrabbit/site/trunk/src/site/markdown/creating-releases.md
URL: http://svn.apache.org/viewvc/jackrabbit/site/trunk/src/site/markdown/creating-releases.md?rev=1833917&r1=1833916&r2=1833917&view=diff
==============================================================================
--- jackrabbit/site/trunk/src/site/markdown/creating-releases.md (original)
+++ jackrabbit/site/trunk/src/site/markdown/creating-releases.md Wed Jun 20 14:13:15 2018
@@ -78,10 +78,15 @@ Release management tasks
    doesn't break Oak.
      * Check by building the applicable Oak version using `mvn clean install -PintegrationTesting -Djackrabbit.version=2.x.y-SNAPSHOT`
      * If the update does require changes in Oak, open JIRA tickets and link them to the JIRA tickets tracking the release activity.
-7. Build and deploy the release artifacts with Maven. See [below](#Steps_to_build_the_release_artifacts) for the exact steps.
-8. Do a sanity check that the [staged repository](https://repository.apache.org/index.html#stagingRepositories) on repository.apache.org contains all artifacts (~19 projects for Jackrabbit).
-9. Close the staged repository, giving it a meaningful name, such as "Apache Jackrabbit 2.x.y RC"
-10. Upload the artifacts to https://dist.apache.org/repos/dist/dev/jackrabbit/ as follows:
+7. If this is a stable branch, review changes to export versions which should be avoided (see [OAK-6346](https://issues.apache.org/jira/browse/OAK-6346) for context). Example: review the output of the command below for any changes of `package-info.java`.
+
+        # Oak 1.8 as of June 2018
+        svn diff .  https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.8.4
+
+8. Build and deploy the release artifacts with Maven. See [below](#Steps_to_build_the_release_artifacts) for the exact steps.
+9. Do a sanity check that the [staged repository](https://repository.apache.org/index.html#stagingRepositories) on repository.apache.org contains all artifacts (~19 projects for Jackrabbit).
+10. Close the staged repository, giving it a meaningful name, such as "Apache Jackrabbit 2.x.y RC"
+11. Upload the artifacts to https://dist.apache.org/repos/dist/dev/jackrabbit/ as follows:
 
         # TARGET - where https://dist.apache.org/repos/dist/dev/jackrabbit/ is checked out
         # SOURCE - where the release was built
@@ -100,11 +105,11 @@ Release management tasks
         svn add oak/$version
         svn commit -m "Apache Jackrabbit Oak $version release candidate" oak/$version
 
-11. Find the vote template (`./target/checkout/target/vote.txt`) generated by the Maven build and follow the instructions to verify the build yourself
-12. Start the vote thread by emailing the applicable mailing list ([Jackrabbit](mailto:dev@jackrabbit.apache.org?subject=%5BVOTE%5D%20Release%20Apache%20Jackrabbit%20x.y.z), [Oak](mailto:oak-dev@jackrabbit.apache.org?subject=%5BVOTE%5D%20Release%20Apache%20Jackrabbit%20Oak%20x.y.z))
-13. Mark the version as released in Jira: [Jackrabbit Jira](https://issues.apache.org/jira/plugins/servlet/project-config/JCR/versions),
+12. Find the vote template (`./target/checkout/target/vote.txt`) generated by the Maven build and follow the instructions to verify the build yourself
+13. Start the vote thread by emailing the applicable mailing list ([Jackrabbit](mailto:dev@jackrabbit.apache.org?subject=%5BVOTE%5D%20Release%20Apache%20Jackrabbit%20x.y.z), [Oak](mailto:oak-dev@jackrabbit.apache.org?subject=%5BVOTE%5D%20Release%20Apache%20Jackrabbit%20Oak%20x.y.z))
+14. Mark the version as released in Jira: [Jackrabbit Jira](https://issues.apache.org/jira/plugins/servlet/project-config/JCR/versions),
    [Oak Jira](https://issues.apache.org/jira/plugins/servlet/project-config/OAK/versions). You'll see all the defined project versions. From the settings menu, choose 'Release' on the version.
-14. Wait 72 hours (we usually allow three business days, so be careful when a weekend is ahead)
+15. Wait 72 hours (we usually allow three business days, so be careful when a weekend is ahead)
 
 ### Part II: after the release vote

Re: svn commit: r1833917 - /jackrabbit/site/trunk/src/site/markdown/creating-releases.md

Posted by Julian Reschke <ju...@gmx.de>.
On 2018-06-21 11:26, Davide Giannella wrote:
> On 20/06/2018 15:13, reschke@apache.org wrote:
>> +7. If this is a stable branch, review changes to export versions which should be avoided (see [OAK-6346](https://issues.apache.org/jira/browse/OAK-6346) for context). Example: review the output of the command below for any changes of `package-info.java`.
>> +
>> +        # Oak 1.8 as of June 2018
>> +        svn diff .  https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.8.4
> 
> Agree on this of course. However a manual review is always very error-prone.
> 
> Aren't there any tools to cross-check this aspect? Possibly maven that
> could e plugged into the `release` profile so that it will fail the
> release if anything change? Or even better enabled by default so that it
> will fail any build?

Well, the question is whether we always want to fail it in this case...

Re: svn commit: r1833917 - /jackrabbit/site/trunk/src/site/markdown/creating-releases.md

Posted by Davide Giannella <da...@apache.org>.
On 20/06/2018 15:13, reschke@apache.org wrote:
> +7. If this is a stable branch, review changes to export versions which should be avoided (see [OAK-6346](https://issues.apache.org/jira/browse/OAK-6346) for context). Example: review the output of the command below for any changes of `package-info.java`.
> +
> +        # Oak 1.8 as of June 2018
> +        svn diff .  https://svn.apache.org/repos/asf/jackrabbit/oak/tags/jackrabbit-oak-1.8.4

Agree on this of course. However a manual review is always very error-prone.

Aren't there any tools to cross-check this aspect? Possibly maven that
could e plugged into the `release` profile so that it will fail the
release if anything change? Or even better enabled by default so that it
will fail any build?

D.