You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/07 01:25:37 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
nsivabalan opened a new pull request #4755:
URL: https://github.com/apache/hudi/pull/4755
## What is the purpose of the pull request
When begin instantime for incremental pull is missing from source hudi table's timeline (due to archival), we support two strategies. read from latest and read upto latest. Read from latest is an incremental pull just with latest commit. Read upto latest is a snapshot query since the puller do not know what exactly to pull. There was some bug in this flow and have fixed it.
For eg, lets say source hudi table has the following timeline
C1, C2... C10.
commits until C4 are archived.
When the puller sets read upto latest with following begin timestamp:
Option.empty()
Or
C1
Or
C2
Or
C3
All of the above will result in snapshot query (or full table scan) with the fix in this patch.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1030984248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1030981343
@harsh1231 @rmahindra123 : can you folks review this patch please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031022036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#discussion_r800485408
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -101,24 +101,31 @@ public S3EventsHoodieIncrSource(
? lastCkptStr.get().isEmpty() ? Option.empty() : lastCkptStr
: Option.empty();
- Pair<String, String> instantEndpts =
+ Pair<String, Pair<String, String>> queryTypeAndInstantEndpts =
IncrSourceHelper.calculateBeginAndEndInstants(
sparkContext, srcPath, numInstantsPerFetch, beginInstant, missingCheckpointStrategy);
- if (instantEndpts.getKey().equals(instantEndpts.getValue())) {
- LOG.warn("Already caught up. Begin Checkpoint was :" + instantEndpts.getKey());
- return Pair.of(Option.empty(), instantEndpts.getKey());
+ if (queryTypeAndInstantEndpts.getValue().getKey().equals(queryTypeAndInstantEndpts.getValue().getValue())) {
+ LOG.warn("Already caught up. Begin Checkpoint was :" + queryTypeAndInstantEndpts.getKey());
+ return Pair.of(Option.empty(), queryTypeAndInstantEndpts.getKey());
}
+ DataFrameReader metaReader = null;
// Do incremental pull. Set end instant if available.
- DataFrameReader metaReader = sparkSession.read().format("org.apache.hudi")
- .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
- .option(DataSourceReadOptions.BEGIN_INSTANTTIME().key(), instantEndpts.getLeft())
- .option(DataSourceReadOptions.END_INSTANTTIME().key(), instantEndpts.getRight());
+ if (queryTypeAndInstantEndpts.getKey().equals(DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())) {
+ metaReader = sparkSession.read().format("org.apache.hudi")
+ .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
+ .option(DataSourceReadOptions.BEGIN_INSTANTTIME().key(), queryTypeAndInstantEndpts.getRight().getLeft())
+ .option(DataSourceReadOptions.END_INSTANTTIME().key(), queryTypeAndInstantEndpts.getRight().getRight());
+ } else {
+ // if checkpoint is missing from source table, and if strategy is set to READ_UPTO_LATEST_COMMIT, we have to issue snapshot query
+ metaReader = sparkSession.read().format("org.apache.hudi")
+ .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_SNAPSHOT_OPT_VAL());
Review comment:
@nsivabalan how can we support filtering data which is consumed till last checkpoint for snapshot query ?
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java
##########
@@ -88,15 +89,15 @@ private static String getStrictlyLowerTimestamp(String timestamp) {
}
});
- if (!beginInstantTime.equals(DEFAULT_BEGIN_TIMESTAMP)) {
+ if (missingCheckpointStrategy == MissingCheckpointStrategy.READ_LATEST) {
Review comment:
if (checkpoint is not present) or (checkpoint is present but checkpoint commit is not present in active timeline ) {
SNAPSHOT_QUERY
}
I think this logic is missing here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031382754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
}, {
"hash" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
* 0ebabd02db6b5c9b376132e6c44ccd274531b917 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031022036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1030982712
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031385036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
}, {
"hash" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761",
"triggerID" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
* 0ebabd02db6b5c9b376132e6c44ccd274531b917 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#discussion_r800575366
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -101,24 +101,31 @@ public S3EventsHoodieIncrSource(
? lastCkptStr.get().isEmpty() ? Option.empty() : lastCkptStr
: Option.empty();
- Pair<String, String> instantEndpts =
+ Pair<String, Pair<String, String>> queryTypeAndInstantEndpts =
IncrSourceHelper.calculateBeginAndEndInstants(
sparkContext, srcPath, numInstantsPerFetch, beginInstant, missingCheckpointStrategy);
- if (instantEndpts.getKey().equals(instantEndpts.getValue())) {
- LOG.warn("Already caught up. Begin Checkpoint was :" + instantEndpts.getKey());
- return Pair.of(Option.empty(), instantEndpts.getKey());
+ if (queryTypeAndInstantEndpts.getValue().getKey().equals(queryTypeAndInstantEndpts.getValue().getValue())) {
+ LOG.warn("Already caught up. Begin Checkpoint was :" + queryTypeAndInstantEndpts.getKey());
+ return Pair.of(Option.empty(), queryTypeAndInstantEndpts.getKey());
}
+ DataFrameReader metaReader = null;
// Do incremental pull. Set end instant if available.
- DataFrameReader metaReader = sparkSession.read().format("org.apache.hudi")
- .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
- .option(DataSourceReadOptions.BEGIN_INSTANTTIME().key(), instantEndpts.getLeft())
- .option(DataSourceReadOptions.END_INSTANTTIME().key(), instantEndpts.getRight());
+ if (queryTypeAndInstantEndpts.getKey().equals(DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())) {
+ metaReader = sparkSession.read().format("org.apache.hudi")
+ .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_INCREMENTAL_OPT_VAL())
+ .option(DataSourceReadOptions.BEGIN_INSTANTTIME().key(), queryTypeAndInstantEndpts.getRight().getLeft())
+ .option(DataSourceReadOptions.END_INSTANTTIME().key(), queryTypeAndInstantEndpts.getRight().getRight());
+ } else {
+ // if checkpoint is missing from source table, and if strategy is set to READ_UPTO_LATEST_COMMIT, we have to issue snapshot query
+ metaReader = sparkSession.read().format("org.apache.hudi")
+ .option(DataSourceReadOptions.QUERY_TYPE().key(), DataSourceReadOptions.QUERY_TYPE_SNAPSHOT_OPT_VAL());
Review comment:
fixing this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031382754
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
}, {
"hash" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
* 0ebabd02db6b5c9b376132e6c44ccd274531b917 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031479578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
}, {
"hash" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761",
"triggerID" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ebabd02db6b5c9b376132e6c44ccd274531b917 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4755:
URL: https://github.com/apache/hudi/pull/4755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031380635
@harsh1231 : addressed your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1032307197
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
}, {
"hash" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761",
"triggerID" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"triggerType" : "PUSH"
}, {
"hash" : "1b85927dcdefc15cc5cbfb76ac0ac1cdeef49c17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b85927dcdefc15cc5cbfb76ac0ac1cdeef49c17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ebabd02db6b5c9b376132e6c44ccd274531b917 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761)
* 1b85927dcdefc15cc5cbfb76ac0ac1cdeef49c17 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#discussion_r800576733
##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java
##########
@@ -88,15 +89,15 @@ private static String getStrictlyLowerTimestamp(String timestamp) {
}
});
- if (!beginInstantTime.equals(DEFAULT_BEGIN_TIMESTAMP)) {
+ if (missingCheckpointStrategy == MissingCheckpointStrategy.READ_LATEST) {
Review comment:
its not required. if begin timestamp is empty we check the missing checkpoint strategy to determine the right values for begin timestamp and end timestamp.
and later we just rely on the strategy to determine whether we want to make incr query or snapshot query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031385036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
}, {
"hash" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761",
"triggerID" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
* 0ebabd02db6b5c9b376132e6c44ccd274531b917 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1031479578
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
}, {
"hash" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761",
"triggerID" : "0ebabd02db6b5c9b376132e6c44ccd274531b917",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ebabd02db6b5c9b376132e6c44ccd274531b917 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5761)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1030984248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5750)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4755: [HUDI-3361] Fixing missing begin checkpoint in HoodieIncremental pull
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4755:
URL: https://github.com/apache/hudi/pull/4755#issuecomment-1030982712
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2e0f5b6aedcf426d35241bae2357019197274760",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e0f5b6aedcf426d35241bae2357019197274760",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e0f5b6aedcf426d35241bae2357019197274760 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org