You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "myjimmy (via GitHub)" <gi...@apache.org> on 2024/01/15 05:27:29 UTC
[PR] GUACAMOLE-1907: Removed the double line breaks. [guacamole-server]
myjimmy opened a new pull request, #478:
URL: https://github.com/apache/guacamole-server/pull/478
I have removed the double line breaks incompatible to the coding style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1907: Removed the double line breaks. [guacamole-server]
Posted by "myjimmy (via GitHub)" <gi...@apache.org>.
myjimmy commented on PR #478:
URL: https://github.com/apache/guacamole-server/pull/478#issuecomment-1956942423
@necouchman I've reverted the changes in the `README` file by following your 1st opinion.
And, please let me know what I need to do for handling your 2nd opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1907: Removed the double line breaks. [guacamole-server]
Posted by "myjimmy (via GitHub)" <gi...@apache.org>.
myjimmy commented on code in PR #478:
URL: https://github.com/apache/guacamole-server/pull/478#discussion_r1454147396
##########
README:
##########
@@ -14,7 +14,6 @@ A full manual is available as well:
http://guacamole.apache.org/doc/gug/
-
Review Comment:
@necouchman I've re-changed the `README` file to keep them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1907: Removed the double line breaks. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #478:
URL: https://github.com/apache/guacamole-server/pull/478#discussion_r1454078622
##########
README:
##########
@@ -14,7 +14,6 @@ A full manual is available as well:
http://guacamole.apache.org/doc/gug/
-
Review Comment:
We might want to consider leaving them in the `README` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1907: Removed the double line breaks. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #478:
URL: https://github.com/apache/guacamole-server/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org