You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/13 13:05:34 UTC
[GitHub] [skywalking-java] xiaolongzuo opened a new pull request, #347: Transport maybe is not a EnhancedInstance.
xiaolongzuo opened a new pull request, #347:
URL: https://github.com/apache/skywalking-java/pull/347
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <Transport maybe is not a EnhancedInstance. For example, a TFrameTransport encapsulating TSocket.>
- [ ] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist π ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== π Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1277606897
> Fix <Transport maybe is not a EnhancedInstance. For example, a TFrameTransport encapsulating TSocket.>
So, in `TFrameTransport` case, `UNKNOWN` is good enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1295754256
This PR has no update in half month. I have to close this.
If you want to continue on this, let's know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1279952664
Are you going to explain what you are proposing to change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaolongzuo commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
xiaolongzuo commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1308119901
> > Fix <Transport maybe is not a EnhancedInstance. For example, a TFrameTransport encapsulating TSocket.>
>
> So, in `TFrameTransport` case, `UNKNOWN` is good enough?
The best way is to enumerate all the situations and take out the correct peers for these situations. However, I'm not sure of any other situations. TFrameTransport is just one of the ones I encounter in my own use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng closed pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #347: Transport maybe is not a EnhancedInstance.
URL: https://github.com/apache/skywalking-java/pull/347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1308132050
If you still want to finish this PR, please follow the comments of the review.
About the UNKNOWN, I just want to make sure which field is going to be set as UNKNOW and how it looks like on the UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xiaolongzuo commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
xiaolongzuo commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1308345950
> If you still want to finish this PR, please follow the comments of the review.
1γWhich field is going to be set as UNKNOWοΌ
AοΌPeer of exit span, likes below.
<img width="981" alt="image" src="https://user-images.githubusercontent.com/5348137/200769831-157ecb3c-170c-4381-8246-d76fc8e613ba.png">
2γHow it looks like on the UI?
AοΌI think it should be UNKNOWN in the peer, but I haven't tested this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1308363642
Peer as UNKNOWN? Then the node of topology would be unknown, this seems not right.
As on the client side, you should be able to get remote service logic name, or IP/DNS address, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #347: Transport maybe is not a EnhancedInstance.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #347:
URL: https://github.com/apache/skywalking-java/pull/347#issuecomment-1277605721
You should use `instanceof` rather than a `catch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org