You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/31 11:42:34 UTC

Review Request 32685: LENS-471 : Fix NPE in deciding priory

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32685/
-----------------------------------------------------------

Review request for lens, Jaideep dhok and Rajat Khandelwal.


Bugs: LENS-471
    https://issues.apache.org/jira/browse/LENS-471


Repository: lens


Description
-------

Fixes getting table weight when it is null.
Also, moved unsetting rewriterPlan to completion than launching


Diffs
-----

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java c0156e5 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java f02490b 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 2fd592a 

Diff: https://reviews.apache.org/r/32685/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.108s]
[INFO] Lens .............................................. SUCCESS [1.747s]
[INFO] Lens API .......................................... SUCCESS [5.461s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.185s]
[INFO] Lens Cube ......................................... SUCCESS [2:14.132s]
[INFO] Lens DB storage ................................... SUCCESS [10.514s]
[INFO] Lens Query Library ................................ SUCCESS [4.951s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:32.595s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [19.067s]
[INFO] Lens Server ....................................... SUCCESS [4:38.968s]
[INFO] Lens client ....................................... SUCCESS [21.184s]
[INFO] Lens CLI .......................................... SUCCESS [2:39.787s]
[INFO] Lens Examples ..................................... SUCCESS [0.787s]
[INFO] Lens Distribution ................................. SUCCESS [9.238s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:01.659s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.548s]
[INFO] Lens Regression ................................... SUCCESS [0.462s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:33.278s
[INFO] Finished at: Tue Mar 31 09:30:48 UTC 2015
[INFO] Final Memory: 97M/1320M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32685: LENS-471 : Fix NPE in deciding priory

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32685/#review78360
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On March 31, 2015, 9:42 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32685/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 9:42 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
> 
> 
> Bugs: LENS-471
>     https://issues.apache.org/jira/browse/LENS-471
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Fixes getting table weight when it is null.
> Also, moved unsetting rewriterPlan to completion than launching
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java c0156e5 
>   lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java f02490b 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 2fd592a 
> 
> Diff: https://reviews.apache.org/r/32685/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.108s]
> [INFO] Lens .............................................. SUCCESS [1.747s]
> [INFO] Lens API .......................................... SUCCESS [5.461s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.185s]
> [INFO] Lens Cube ......................................... SUCCESS [2:14.132s]
> [INFO] Lens DB storage ................................... SUCCESS [10.514s]
> [INFO] Lens Query Library ................................ SUCCESS [4.951s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:32.595s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [19.067s]
> [INFO] Lens Server ....................................... SUCCESS [4:38.968s]
> [INFO] Lens client ....................................... SUCCESS [21.184s]
> [INFO] Lens CLI .......................................... SUCCESS [2:39.787s]
> [INFO] Lens Examples ..................................... SUCCESS [0.787s]
> [INFO] Lens Distribution ................................. SUCCESS [9.238s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.659s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.548s]
> [INFO] Lens Regression ................................... SUCCESS [0.462s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:33.278s
> [INFO] Finished at: Tue Mar 31 09:30:48 UTC 2015
> [INFO] Final Memory: 97M/1320M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 32685: LENS-471 : Fix NPE in deciding priority

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32685/
-----------------------------------------------------------

(Updated March 31, 2015, 11:40 a.m.)


Review request for lens, Jaideep dhok and Rajat Khandelwal.


Summary (updated)
-----------------

LENS-471 : Fix NPE in deciding priority


Bugs: LENS-471
    https://issues.apache.org/jira/browse/LENS-471


Repository: lens


Description
-------

Fixes getting table weight when it is null.
Also, moved unsetting rewriterPlan to completion than launching


Diffs
-----

  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java c0156e5 
  lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java f02490b 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 2fd592a 

Diff: https://reviews.apache.org/r/32685/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.108s]
[INFO] Lens .............................................. SUCCESS [1.747s]
[INFO] Lens API .......................................... SUCCESS [5.461s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.185s]
[INFO] Lens Cube ......................................... SUCCESS [2:14.132s]
[INFO] Lens DB storage ................................... SUCCESS [10.514s]
[INFO] Lens Query Library ................................ SUCCESS [4.951s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:32.595s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [19.067s]
[INFO] Lens Server ....................................... SUCCESS [4:38.968s]
[INFO] Lens client ....................................... SUCCESS [21.184s]
[INFO] Lens CLI .......................................... SUCCESS [2:39.787s]
[INFO] Lens Examples ..................................... SUCCESS [0.787s]
[INFO] Lens Distribution ................................. SUCCESS [9.238s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:01.659s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.548s]
[INFO] Lens Regression ................................... SUCCESS [0.462s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:33.278s
[INFO] Finished at: Tue Mar 31 09:30:48 UTC 2015
[INFO] Final Memory: 97M/1320M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu