You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Juanjo Marron <jm...@us.ibm.com> on 2016/04/05 23:46:04 UTC
Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/
-----------------------------------------------------------
Review request for Ambari and Jayush Luniya.
Bugs: AMBARI-15577
https://issues.apache.org/jira/browse/AMBARI-15577
Repository: ambari
Description
-------
Featurize HDP specific logic from HIVE service
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py f7d817a
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 41508b4
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py e1c0c42
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py 9f32d16
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 70b8921
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 7a3c12e
Diff: https://reviews.apache.org/r/45778/diff/
Testing
-------
----------------------------------------------------------------------
Ran 253 tests in 6.681s
OK
----------------------------------------------------------------------
Failed tests:
FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py", line 761, in test_stop_during_upgrade
tries=1, user='hive')
File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 262, in assertResourceCalledByIndex
self.assertEquals(name, resource.name)
AssertionError: 'hive --config /usr/hdp/current/hive-server2/conf/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' != 'hive --config /etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434'
----------------------------------------------------------------------
Total run:933
Total errors:0
Total failures:1
Thanks,
Juanjo Marron
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127289
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py (line 199)
<https://reviews.apache.org/r/45778/#comment190538>
Rename to hive_purge_table instead
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py (line 200)
<https://reviews.apache.org/r/45778/#comment190540>
Rename to "Hive purge table support" instead
Reference for purge option.
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-DropTable
If PURGE is specified, the table data does not go to the .Trash/Current directory and so cannot be retrieved in the event of a mistaken DROP.
- Jayush Luniya
On April 5, 2016, 9:46 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:46 p.m.)
>
>
> Review request for Ambari and Jayush Luniya.
>
>
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Featurize HDP specific logic from HIVE service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py f7d817a
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 41508b4
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py e1c0c42
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py 9f32d16
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 70b8921
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 7a3c12e
>
> Diff: https://reviews.apache.org/r/45778/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 253 tests in 6.681s
>
> OK
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py", line 761, in test_stop_during_upgrade
> tries=1, user='hive')
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 262, in assertResourceCalledByIndex
> self.assertEquals(name, resource.name)
> AssertionError: 'hive --config /usr/hdp/current/hive-server2/conf/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' != 'hive --config /etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434'
>
> ----------------------------------------------------------------------
> Total run:933
> Total errors:0
> Total failures:1
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127292
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py (line 235)
<https://reviews.apache.org/r/45778/#comment190541>
I guess this should be CONFIG_VERSIONING feature check?
- Jayush Luniya
On April 5, 2016, 9:46 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:46 p.m.)
>
>
> Review request for Ambari and Jayush Luniya.
>
>
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Featurize HDP specific logic from HIVE service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py f7d817a
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 41508b4
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py e1c0c42
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py 9f32d16
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 70b8921
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 7a3c12e
>
> Diff: https://reviews.apache.org/r/45778/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 253 tests in 6.681s
>
> OK
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py", line 761, in test_stop_during_upgrade
> tries=1, user='hive')
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 262, in assertResourceCalledByIndex
> self.assertEquals(name, resource.name)
> AssertionError: 'hive --config /usr/hdp/current/hive-server2/conf/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' != 'hive --config /etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434'
>
> ----------------------------------------------------------------------
> Total run:933
> Total errors:0
> Total failures:1
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Juanjo Marron <jm...@us.ibm.com>.
> On April 6, 2016, 7:04 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py, line 113
> > <https://reviews.apache.org/r/45778/diff/1/?file=1326879#file1326879line113>
> >
> > Keep cmd as a list
command changed back to list type.
Initially I followed other examples on hive_service_interactive.py, such as:
pid_file = format("{hive_pid_dir}/{hive_interactive_pid}")
cmd = format("{start_hiveserver2_interactive_path} {hive_pid_dir}/hive-server2-interactive.out {hive_log_dir}/hive-server2-interactive.err {pid_file} {hive_server_interactive_conf_dir} {hive_log_dir}"
- Juanjo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127295
-----------------------------------------------------------
On April 5, 2016, 9:46 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:46 p.m.)
>
>
> Review request for Ambari and Jayush Luniya.
>
>
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Featurize HDP specific logic from HIVE service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py f7d817a
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 41508b4
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py e1c0c42
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py 9f32d16
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 70b8921
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 7a3c12e
>
> Diff: https://reviews.apache.org/r/45778/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 253 tests in 6.681s
>
> OK
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py", line 761, in test_stop_during_upgrade
> tries=1, user='hive')
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 262, in assertResourceCalledByIndex
> self.assertEquals(name, resource.name)
> AssertionError: 'hive --config /usr/hdp/current/hive-server2/conf/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' != 'hive --config /etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434'
>
> ----------------------------------------------------------------------
> Total run:933
> Total errors:0
> Total failures:1
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127295
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py (line 113)
<https://reviews.apache.org/r/45778/#comment190544>
Keep cmd as a list
- Jayush Luniya
On April 5, 2016, 9:46 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:46 p.m.)
>
>
> Review request for Ambari and Jayush Luniya.
>
>
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Featurize HDP specific logic from HIVE service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py f7d817a
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 41508b4
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py e1c0c42
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py 9f32d16
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 70b8921
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 7a3c12e
>
> Diff: https://reviews.apache.org/r/45778/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 253 tests in 6.681s
>
> OK
> ----------------------------------------------------------------------
> Failed tests:
> FAIL: test_stop_during_upgrade (test_hive_server.TestHiveServer)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/jmarron/git/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py", line 761, in test_stop_during_upgrade
> tries=1, user='hive')
> File "/home/jmarron/git/ambari/ambari-server/src/test/python/stacks/utils/RMFTestCase.py", line 262, in assertResourceCalledByIndex
> self.assertEquals(name, resource.name)
> AssertionError: 'hive --config /usr/hdp/current/hive-server2/conf/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' != 'hive --config /etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434'
>
> ----------------------------------------------------------------------
> Total run:933
> Total errors:0
> Total failures:1
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127523
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py (line 52)
<https://reviews.apache.org/r/45778/#comment190868>
I wouldn't use stack_name_lowercase, just use stack_name everywhere.
Do keep stack_name_uppercase
- Alejandro Fernandez
On April 6, 2016, 8:49 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 8:49 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Featurize HDP specific logic from HIVE service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py f7d817a
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 4fc3489
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py e1c0c42
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py 9f32d16
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 70b8921
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 7a3c12e
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8d0467a
>
> Diff: https://reviews.apache.org/r/45778/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [20.236s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.672s]
> [INFO] Ambari Web ........................................ SUCCESS [1:44.395s]
> [INFO] Ambari Views ...................................... SUCCESS [8.415s]
> [INFO] Ambari Admin View ................................. SUCCESS [26.967s]
> [INFO] ambari-metrics .................................... SUCCESS [0.875s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.270s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.132s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.734s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.434s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.894s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [41.267s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.683s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [24.118s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [50.671s]
> [INFO] Ambari Server ..................................... SUCCESS [1:07.610s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [1.088s]
> [INFO] Ambari Agent ...................................... SUCCESS [12.194s]
> [INFO] Ambari Client ..................................... SUCCESS [0.081s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.683s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [14.871s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.069s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.049s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.821s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6:35.996s
> [INFO] Finished at: Wed Apr 06 01:38:42 PDT 2016
> [INFO] Final Memory: 112M/721M
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/#review127756
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On April 7, 2016, 5:45 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45778/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 5:45 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-15577
> https://issues.apache.org/jira/browse/AMBARI-15577
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Featurize HDP specific logic from HIVE service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 055a576
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 8d31fdc
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8e4e6df
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py f1560ab
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 2412c15
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 0388aa2
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8d0467a
>
> Diff: https://reviews.apache.org/r/45778/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [4.916s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.502s]
> [INFO] Ambari Web ........................................ SUCCESS [1:29.956s]
> [INFO] Ambari Views ...................................... SUCCESS [5.054s]
> [INFO] Ambari Admin View ................................. SUCCESS [11.395s]
> [INFO] ambari-metrics .................................... SUCCESS [0.289s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.785s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.050s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.568s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [2.354s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [0.919s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [31.990s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [1.767s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [22.924s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [49.426s]
> [INFO] Ambari Server ..................................... SUCCESS [1:05.826s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [1.283s]
> [INFO] Ambari Agent ...................................... SUCCESS [11.982s]
> [INFO] Ambari Client ..................................... SUCCESS [0.061s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.393s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [13.825s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.055s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.068s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [10.794s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 5:29.110s
> [INFO] Finished at: Thu Apr 07 10:42:41 PDT 2016
> [INFO] Final Memory: 114M/778M
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/
-----------------------------------------------------------
(Updated April 7, 2016, 5:45 p.m.)
Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
Bugs: AMBARI-15577
https://issues.apache.org/jira/browse/AMBARI-15577
Repository: ambari
Description
-------
Featurize HDP specific logic from HIVE service
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 055a576
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 8d31fdc
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 8e4e6df
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py f1560ab
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 2412c15
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 0388aa2
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8d0467a
Diff: https://reviews.apache.org/r/45778/diff/
Testing (updated)
-------
mvn clean test -DskipSurefireTests
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.916s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.502s]
[INFO] Ambari Web ........................................ SUCCESS [1:29.956s]
[INFO] Ambari Views ...................................... SUCCESS [5.054s]
[INFO] Ambari Admin View ................................. SUCCESS [11.395s]
[INFO] ambari-metrics .................................... SUCCESS [0.289s]
[INFO] Ambari Metrics Common ............................. SUCCESS [0.785s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.050s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.568s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [2.354s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [0.919s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [31.990s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [1.767s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [22.924s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [49.426s]
[INFO] Ambari Server ..................................... SUCCESS [1:05.826s]
[INFO] Ambari Functional Tests ........................... SUCCESS [1.283s]
[INFO] Ambari Agent ...................................... SUCCESS [11.982s]
[INFO] Ambari Client ..................................... SUCCESS [0.061s]
[INFO] Ambari Python Client .............................. SUCCESS [0.393s]
[INFO] Ambari Groovy Client .............................. SUCCESS [13.825s]
[INFO] Ambari Shell ...................................... SUCCESS [0.055s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.068s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.794s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5:29.110s
[INFO] Finished at: Thu Apr 07 10:42:41 PDT 2016
[INFO] Final Memory: 114M/778M
Thanks,
Juanjo Marron
Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service
Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45778/
-----------------------------------------------------------
(Updated April 6, 2016, 8:49 p.m.)
Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
Changes
-------
Added changes according to comments in the initial review and changes in UTs (test_hive_sever.py) as proposed by Jayush:
Bugs: AMBARI-15577
https://issues.apache.org/jira/browse/AMBARI-15577
Repository: ambari
Description
-------
Featurize HDP specific logic from HIVE service
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py f7d817a
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 4fc3489
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_metastore.py 42485b6
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py 941b70c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py 4153821
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 3c51d39
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py ba2a129
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py 7fee2b3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py f7f1377
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py e1c0c42
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_upgrade.py 8045528
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py 3aa6536
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py 9f32d16
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 70b8921
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py d71e061
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py b95f6f3
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py b0a876d
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py 10e0990
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 7a3c12e
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8d0467a
Diff: https://reviews.apache.org/r/45778/diff/
Testing (updated)
-------
mvn clean test -DskipSurefireTests
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [20.236s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.672s]
[INFO] Ambari Web ........................................ SUCCESS [1:44.395s]
[INFO] Ambari Views ...................................... SUCCESS [8.415s]
[INFO] Ambari Admin View ................................. SUCCESS [26.967s]
[INFO] ambari-metrics .................................... SUCCESS [0.875s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.270s]
[INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [1.132s]
[INFO] Ambari Metrics Flume Sink ......................... SUCCESS [0.734s]
[INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [1.434s]
[INFO] Ambari Metrics Storm Sink ......................... SUCCESS [1.894s]
[INFO] Ambari Metrics Collector .......................... SUCCESS [41.267s]
[INFO] Ambari Metrics Monitor ............................ SUCCESS [2.683s]
[INFO] Ambari Metrics Grafana ............................ SUCCESS [24.118s]
[INFO] Ambari Metrics Assembly ........................... SUCCESS [50.671s]
[INFO] Ambari Server ..................................... SUCCESS [1:07.610s]
[INFO] Ambari Functional Tests ........................... SUCCESS [1.088s]
[INFO] Ambari Agent ...................................... SUCCESS [12.194s]
[INFO] Ambari Client ..................................... SUCCESS [0.081s]
[INFO] Ambari Python Client .............................. SUCCESS [0.683s]
[INFO] Ambari Groovy Client .............................. SUCCESS [14.871s]
[INFO] Ambari Shell ...................................... SUCCESS [0.069s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.049s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [10.821s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:35.996s
[INFO] Finished at: Wed Apr 06 01:38:42 PDT 2016
[INFO] Final Memory: 112M/721M
Thanks,
Juanjo Marron