You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Gagandeep singh <ga...@gmail.com> on 2010/11/26 15:28:35 UTC

Fwd: Issue 3213042: Injecting Provider allowing it to be overridden

 Reviewers: dev@shindig.apache.org

Description:


Use case:
- per container overriding of DefaultConfig.
Currently not possible, but with this patch, one should be able to add a
provider which can provide different values for DefaultConfig (say for different
containers).
Here is a sample snippet which allows the same:

protected void configure() {
  bind(DefaultConfig.class)..toProvider(DefaultConfigProvider.class);
}

public static class DefaultConfigProvider implements Provider<DefaultConfig> {
  public DefaultConfig get() {
    if (container == accel) {
      // Override
      return new DefaultConfig( ... );  // override default params
    } else {
      return defaultConfig;
    }
  }
}

Please review this at *http://codereview.appspot.com/3213042/*

Affected files:
  M
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/ContentRewriterFeature.java
  M
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriterTest.java
  M
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingResponseRewriterTest.java
  M
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/BaseRewriterTestCase.java
  M
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriterTestBase.java

Thanks
Gagan