[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #4387: Fix page index pruning fail on complex_expr

[GitBox <gi...@apache.org>]

Ted-Jiang commented on code in PR #4387:
URL: https://github.com/apache/arrow-datafusion/pull/4387#discussion_r1032895799


##########
datafusion/core/tests/parquet/page_pruning.rs:
##########
@@ -495,22 +491,20 @@ async fn prune_f64_lt() {
 }
 
 #[tokio::test]
-#[ignore]
 async fn prune_f64_scalar_fun_and_gt() {
     // result of sql "SELECT * FROM t where abs(f - 1) <= 0.000001  and f >= 0.1"
     // only use "f >= 0" to prune
     test_prune(
         Scenario::Float64,
         "SELECT * FROM t where abs(f - 1) <= 0.000001  and f >= 0.1",
         Some(0),
-        Some(2),
+        Some(10),

Review Comment:
    only use "f >= 0" to prune it will prune two pages (each 5 rows), so make it 10 make sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org