[GitHub] [incubator-mxnet] eric-haibin-lin commented on a change in pull request #14354: [WIP] Ndarray cumsum

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #14354: [WIP] Ndarray cumsum
URL: https://github.com/apache/incubator-mxnet/pull/14354#discussion_r266260312
 
 

 ##########
 File path: src/operator/tensor/cumulative_op.h
 ##########
 @@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ *  Copyright (c) 2015 by Contributors
+ * \file cumulative_op.h
+ * \brief Function definition of cumulative operators
+ */
+#ifndef MXNET_OPERATOR_TENSOR_CUMULATIVE_OP_H_
+#define MXNET_OPERATOR_TENSOR_CUMULATIVE_OP_H_
+
+#include <mxnet/operator_util.h>
+#include <vector>
+#include "../mshadow_op.h"
+#include "../mxnet_op.h"
+#include "../operator_common.h"
+#include "../elemwise_op_common.h"
+#include "../tensor/init_op.h"
+
+namespace mxnet {
+namespace op {
+
+struct CumsumParam : public dmlc::Parameter<CumsumParam> {
+  dmlc::optional<int> axis;
+  // bool keepdims; Do we need keepdims or not for cum_sum?
 
 Review comment:
   numpy does not have this option. Let's keep it consistent with numpy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services