You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/03 15:48:05 UTC
[GitHub] [tvm] trahman-quic opened a new pull request, #13282: [TOPI][Hexagon] Implement adaptive_avg_pool1d for hexagon
trahman-quic opened a new pull request, #13282:
URL: https://github.com/apache/tvm/pull/13282
This PR adds the implementation, test cases and schedules of adaptive_avg_pool1d for hexagon. Input is assumed to be in NCW layout with a size of multiple of croutons . Here we are introducing a new crouton layout ncw-32c64w-2d. The op implementation is for specialized case where output_size is NxCx1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13282:
URL: https://github.com/apache/tvm/pull/13282#issuecomment-1302355703
@trahman-quic pylint has been added to the test files. Please fix the lint issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on PR #13282:
URL: https://github.com/apache/tvm/pull/13282#issuecomment-1315700131
@trahman-quic `allocate_hexagon_array` is moved to the python package. You need to rebase and fix the import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh merged pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #13282:
URL: https://github.com/apache/tvm/pull/13282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] trahman-quic commented on pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
trahman-quic commented on PR #13282:
URL: https://github.com/apache/tvm/pull/13282#issuecomment-1315963048
Hi @mehrdadh thank you for suggesting the fix for import. All tests have passed now. If it looks good to you, we can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] trahman-quic commented on pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
trahman-quic commented on PR #13282:
URL: https://github.com/apache/tvm/pull/13282#issuecomment-1314507265
Hi @mehrdadh The lint issues have been fixed but there are some CI tests that are failing. Are these related to my tests? Can you please give me an idea on how to resolve the issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] trahman-quic commented on pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
trahman-quic commented on PR #13282:
URL: https://github.com/apache/tvm/pull/13282#issuecomment-1304158393
> @trahman-quic pylint has been added to the test files. Please fix the lint issues
@mehrdadh The checks are green now. Wanted to ask you if it's good to merge now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13282: [TOPI][Hexagon] Implement adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13282:
URL: https://github.com/apache/tvm/pull/13282#issuecomment-1302311727
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @mehrdadh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mehrdadh commented on a diff in pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon
Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #13282:
URL: https://github.com/apache/tvm/pull/13282#discussion_r1014442295
##########
python/tvm/topi/hexagon/qnn/adaptive_avg_pool1d.py:
##########
@@ -0,0 +1,122 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=invalid-name, unused-variable, unused-argument, too-many-locals
Review Comment:
I don't think we need these. Please remove them and fix the lint issues.
##########
tests/python/contrib/test_hexagon/topi/test_adaptive_avg_pool1d.py:
##########
@@ -0,0 +1,181 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I have added lint for tests in this sub-directory. Let's wait for that PR to merge to avoid conflict. After that merges, you will see lint issues with this test, so I recommend to fix it in the meantime
https://github.com/apache/tvm/pull/13271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org