You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/12/20 22:00:18 UTC
Review Request 54916: GEODE-2215: Fixed flakiness of
ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54916/
-----------------------------------------------------------
Review request for geode, nabarun nag and Dan Smith.
Repository: geode
Description
-------
Fixes to make the test less timing based.
Diffs
-----
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 3ed867a
Diff: https://reviews.apache.org/r/54916/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 54916: GEODE-2215: Fixed flakiness of
ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54916/#review159997
-----------------------------------------------------------
Fix it, then Ship it!
It looks good, but I think we really need to clean up this getSenderStats method at some point because that's a lame API.
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 103)
<https://reviews.apache.org/r/54916/#comment231014>
This getSenderStats method looks like it needs some work - it's returning an list where you have to know the index of the stat?
- Dan Smith
On Dec. 22, 2016, 6:38 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54916/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 6:38 p.m.)
>
>
> Review request for geode, nabarun nag and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fixes to make the test less timing based.
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 3ed867a
>
> Diff: https://reviews.apache.org/r/54916/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 54916: GEODE-2215: Fixed flakiness of
ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread
Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54916/
-----------------------------------------------------------
(Updated Dec. 22, 2016, 6:38 p.m.)
Review request for geode, nabarun nag and Dan Smith.
Changes
-------
Reduced number of puts in test.
Actually verifying what the original test should have been verifying.
Repository: geode
Description
-------
Fixes to make the test less timing based.
Diffs (updated)
-----
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 3ed867a
Diff: https://reviews.apache.org/r/54916/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 54916: GEODE-2215: Fixed flakiness of
ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54916/#review159759
-----------------------------------------------------------
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 100)
<https://reviews.apache.org/r/54916/#comment230808>
Does this test reall need to do 10K puts? Can we scale it down?
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 103)
<https://reviews.apache.org/r/54916/#comment230809>
A 3 second wait seems really short. Likely will cause spurious failures?
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 105)
<https://reviews.apache.org/r/54916/#comment230810>
Maybe stopSender could be triggered by a cache listener in the remote side or something to make this test more deterministic?
- Dan Smith
On Dec. 20, 2016, 10 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54916/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 10 p.m.)
>
>
> Review request for geode, nabarun nag and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Fixes to make the test less timing based.
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 3ed867a
>
> Diff: https://reviews.apache.org/r/54916/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>