[GitHub] tajo pull request: TAJO-1352: Improve the join order algorithm to ...

[hyunsik <gi...@git.apache.org>]

Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/593#discussion_r34440152
  
    --- Diff: tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SchemaUtil.java ---
    @@ -161,4 +161,52 @@ public static String toDisplayString(Schema schema) {
         DDLBuilder.buildSchema(sb, schema);
         return sb.toString();
       }
    +
    +  public static int estimateSchemaSize(Schema schema) {
    --- End diff --
    
    It seems to need some comment because it is hard to image its return value from the function name.
    Also, ```estimateRowSize``` rather than ```schema``` may be more intuitive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---