You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/29 16:06:00 UTC
[jira] [Work logged] (BEAM-6148) Support Go "Unit" tests on
arbitrary runners
[ https://issues.apache.org/jira/browse/BEAM-6148?focusedWorklogId=170692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-170692 ]
ASF GitHub Bot logged work on BEAM-6148:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/18 16:05
Start Date: 29/Nov/18 16:05
Worklog Time Spent: 10m
Work Description: lostluck opened a new pull request #7158: [BEAM-6148] ptest support arbitrary runners
URL: https://github.com/apache/beam/pull/7158
Allow ptest to support arbitrary runners. A user would need to include a TestMain in their test file as well as _ import a runner in question.
eg.
```
import _ ".../beam/runners/my_runner"
func TestMain(m *testing.M) {
ptest.Main(m)
}
```
Then `go test --runner="my_runner"` would execute the tests with my_runner.
ptest.Main has been written to tolerate parsing flags before being invoked, so if other flag manipulations are required they should work as intended. By default, as previously, the direct runner will be used.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 170692)
Time Spent: 10m
Remaining Estimate: 0h
> Support Go "Unit" tests on arbitrary runners
> --------------------------------------------
>
> Key: BEAM-6148
> URL: https://issues.apache.org/jira/browse/BEAM-6148
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There's no clear path to testing pipelines on runners other than the direct runner. It should be possibly to "redirect" tests to use a runner of choice. This would enable more "testy" ValidatesRunner tests in Go.
>
> In particular, users should need to at least _ import the runner they want, and be able to set a flag.
> The tricky bit is ensuring beam.Init is called so that each individual test can convert to WorkerMode when it's spun up as a SDK harness. This can be done by having a TestMain.
> ptest should provide convenience functions to help with this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)