[GitHub] [lucene] dweiss commented on a change in pull request #68: LUCENE-9910: maximize javac lint

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #68:
URL: https://github.com/apache/lucene/pull/68#discussion_r608459064



##########
File path: gradle/java/javac.gradle
##########
@@ -33,27 +33,51 @@ allprojects {
       options.compilerArgs += [
         "-Xlint:-deprecation",
         "-Xlint:-serial",
+        "-Xlint:auxiliaryclass",
         "-Xlint:cast",
         "-Xlint:classfile",
         "-Xlint:dep-ann",
         "-Xlint:divzero",
         "-Xlint:empty",
+        "-Xlint:exports",
         "-Xlint:fallthrough",
         "-Xlint:finally",
+        "-Xlint:opens",
         "-Xlint:options",
+        "-Xlint:overloads",
         "-Xlint:overrides",
+        // TODO: some tests seem to have bad classpaths?
+        // this check seems to be a good sanity check for gradle?
+        // "-Xlint:path",

Review comment:
       These are the default locations for output resource compilation. If the source doesn't have a corresponding input, the output doesn't exist. Looks like a gradle bug to me. Don't know how to fix this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org