You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "adriangb (via GitHub)" <gi...@apache.org> on 2025/11/02 02:57:09 UTC
[PR] feat(physical-expr): add InListStorage enum for array-based storage [datafusion]
adriangb opened a new pull request, #18434:
URL: https://github.com/apache/datafusion/pull/18434
## Summary
Introduces `InListStorage` enum to support both expression-based and array-based storage in `InListExpr`. This enables more efficient memory usage when InList values are homogeneous and can be stored directly as arrays.
## Changes
- Added `InListStorage` enum with `Array(ArrayRef)` and `Exprs(Vec<Arc<dyn PhysicalExpr>>)` variants
- Refactored `InListExpr` to use enum storage (initially uses `Exprs` variant only)
- Added `Set` implementations for primitive array types (`ArraySet`, `StructArraySet`)
- Added `in_list_from_array` helper function for creating InList from arrays
- Updated dependent code to handle `Result` from `list()` method
## Value
- Better memory representation for homogeneous lists
- Infrastructure for future array-based InList optimizations
- Support for struct arrays in InList (multi-column joins)
## Testing
- ✅ All clippy checks pass with `-D warnings`
- ✅ 27 InList tests passing
- ✅ Behavior unchanged (uses `Exprs` variant by default)
## Part of Multi-PR Strategy
This is **PR2 of 7** in the InList pushdown feature breakdown.
**Tier**: Foundation (Tier 1)
**Dependencies**: None (independent)
**Can merge**: As soon as approved (parallel with PR1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat(physical-expr): add InListStorage enum for array-based storage [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb closed pull request #18434: feat(physical-expr): add InListStorage enum for array-based storage
URL: https://github.com/apache/datafusion/pull/18434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org