You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/15 11:45:26 UTC
[GitHub] [spark] wangshengjie123 opened a new pull request, #37522: [SPARK-40083] Add shuffle index cache expire time
wangshengjie123 opened a new pull request, #37522:
URL: https://github.com/apache/spark/pull/37522
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
add shuffle index cache time-based expire policy
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Clean up unused cache save memory.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #37522: [SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy
Posted by GitBox <gi...@apache.org>.
mridulm commented on PR #37522:
URL: https://github.com/apache/spark/pull/37522#issuecomment-1218694738
Agree, if this is for completed applications, we should be handling it in `applicationRemoved`
There is cleanup there already - looks like the cache is not getting evicted from.
The same applies to `indexCache` in `RemoteBlockPushResolver` also. +CC @otterc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37522: [SPARK-40083][SHUFFLE] Add shuffle index cache expire time
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37522:
URL: https://github.com/apache/spark/pull/37522#issuecomment-1214969357
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangshengjie123 commented on pull request #37522: [SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy
Posted by GitBox <gi...@apache.org>.
wangshengjie123 commented on PR #37522:
URL: https://github.com/apache/spark/pull/37522#issuecomment-1216046907
>
Thanks @JoshRosen for review this pr.
We have the the situation in our production environment, we set `spark.shuffle.service.index.cache.size` to 256m, we found it need about 2 day to reach the cache limit size and old cache those apps already finished still in old gen memory.
As you suggested, we adjusted NM memory size to solve the memory problem, also we could adjust cache limit size.
But sometimes we need to face the face business growth and adjust NM memory is an expensive operation, so this pr just a optimization for cache， i am not sure this is a common case but useful for our situation.
Thanks again @JoshRosen for your reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37522: [WIP][SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37522: [WIP][SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy
URL: https://github.com/apache/spark/pull/37522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JoshRosen commented on pull request #37522: [SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy
Posted by GitBox <gi...@apache.org>.
JoshRosen commented on PR #37522:
URL: https://github.com/apache/spark/pull/37522#issuecomment-1218380759
If the primary intent is to clean up cache entries associated with finished Spark applications, is there a way that we could do this more directly?
In `ExternalShuffleBlockResolver.applicationRemoved` it looks like we have some logic that can start an asynchronous background task to clean up the shuffle files. Maybe we could somehow remove the cache entries in a similar manner (e.g. either by doing this during the file deletion, taking advantage of the fact that the cache keys are filenames, or by iterating over the cache's keys and deleting files in the deleted application's directory (we'd have to check the iteration semantic to make sure this is safe)).
Doing this cleanup at application-removal time would avoid the need to have a time-based config (which could be hard to tune appropriately).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangshengjie123 commented on pull request #37522: [SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy
Posted by GitBox <gi...@apache.org>.
wangshengjie123 commented on PR #37522:
URL: https://github.com/apache/spark/pull/37522#issuecomment-1218882973
> Agree with @JoshRosen, if this is for completed applications, we should be handling it in `applicationRemoved` There is cleanup there already - looks like the cache is not getting evicted from.
>
> The same applies to `indexCache` in `RemoteBlockPushResolver` also. +CC @otterc
Yeah, can`t agree more, let me do this，thanks @JoshRosen @mridulm
Change pr to WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37522: [WIP][SPARK-40083][SHUFFLE] Add shuffle index cache timebased expire policy
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37522:
URL: https://github.com/apache/spark/pull/37522#issuecomment-1328139482
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org