You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/03/25 04:46:56 UTC
[kudu-CR] KUDU-2750: Add create and alter timestamp to tables
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12842
Change subject: KUDU-2750: Add create and alter timestamp to tables
......................................................................
KUDU-2750: Add create and alter timestamp to tables
Add create and last alteration time to every table. The
timestamps are persisted with 'SysTablesEntryPB' and
displayed on the 'master:port/tables' page.
Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
4 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/12842/1
--
To view, visit http://gerrit.cloudera.org:8080/12842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
[kudu-CR] KUDU-2750: Add create and alter timestamp to tables
Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12842
to look at the new patch set (#2).
Change subject: KUDU-2750: Add create and alter timestamp to tables
......................................................................
KUDU-2750: Add create and alter timestamp to tables
Add create and last alteration time to every table. The
timestamps are persisted with 'SysTablesEntryPB' and
displayed on the 'master:port/tables' page.
Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
4 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/12842/2
--
To view, visit http://gerrit.cloudera.org:8080/12842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2750: Add create and alter timestamp to tables
Posted by "helifu (Code Review)" <ge...@cloudera.org>.
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 )
Change subject: KUDU-2750: Add create and alter timestamp to tables
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@185
PS1, Line 185: // The create time of the table, in seconds since the epoch.
> nit: add "in seconds since the epoch"
Done
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@186
PS1, Line 186: optional int64 create_timestamp = 10;
> nit: can you rename this and the below field to '_timestamp' instead of '_t
Done
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@187
PS1, Line 187: // The last alter time of the table, in seconds since the epoch.
> same
Done
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc@202
PS1, Line 202: str_create_ti
> style nit: str_create_time
Done
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc@207
PS1, Line 207: table_json["create time"] = EscapeForHtmlToString(str_create_time);
> same
Done
--
To view, visit http://gerrit.cloudera.org:8080/12842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Tue, 26 Mar 2019 03:42:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2750: Add create and alter timestamp to tables
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 )
Change subject: KUDU-2750: Add create and alter timestamp to tables
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Tue, 26 Mar 2019 04:16:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2750: Add create and alter timestamp to tables
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12842 )
Change subject: KUDU-2750: Add create and alter timestamp to tables
......................................................................
KUDU-2750: Add create and alter timestamp to tables
Add create and last alteration time to every table. The
timestamps are persisted with 'SysTablesEntryPB' and
displayed on the 'master:port/tables' page.
Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
Reviewed-on: http://gerrit.cloudera.org:8080/12842
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M www/tables.mustache
4 files changed, 25 insertions(+), 0 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
[kudu-CR] KUDU-2750: Add create and alter timestamp to tables
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12842 )
Change subject: KUDU-2750: Add create and alter timestamp to tables
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto
File src/kudu/master/master.proto:
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@185
PS1, Line 185: // The create time of the table.
nit: add "in seconds since the epoch"
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@186
PS1, Line 186: optional int64 create_time = 10;
nit: can you rename this and the below field to '_timestamp' instead of '_time'? Just to make it extra clear that it's a point in time and not a duration
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master.proto@187
PS1, Line 187: // The last alter time of the table.
same
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc
File src/kudu/master/master_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc@202
PS1, Line 202: strCreateTime
style nit: str_create_time
http://gerrit.cloudera.org:8080/#/c/12842/1/src/kudu/master/master_path_handlers.cc@207
PS1, Line 207: std::string strAlterTime;
same
--
To view, visit http://gerrit.cloudera.org:8080/12842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05719cea26b15fdf2b5667b60c3e89947cdda8
Gerrit-Change-Number: 12842
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 25 Mar 2019 15:49:03 +0000
Gerrit-HasComments: Yes