You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ivan Zuzak (JIRA)" <ji...@apache.org> on 2009/10/15 21:25:31 UTC
[jira] Created: (SHINDIG-1196) Wrong multi-line splitting of long
string constant in wpm RPC transport
Wrong multi-line splitting of long string constant in wpm RPC transport
-----------------------------------------------------------------------
Key: SHINDIG-1196
URL: https://issues.apache.org/jira/browse/SHINDIG-1196
Project: Shindig
Issue Type: Bug
Components: Javascript
Reporter: Ivan Zuzak
Priority: Minor
In features/src/main/javascript/features/rpc/wpm.transport.js a long string is split between two lines using string concatenation like so:
gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
+ ", cannot send cross-domain message");
However, this is wrong and produces the following output in nightly Chromium and Firefox:
""No relay set (used as window.postMessage targetOrigin)NaN"
The proper way to concatenate strings is to use a single "+" character like this:
gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
", cannot send cross-domain message");
which produces the correct output. I've attached a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1196) Wrong multi-line splitting of long
string constant in wpm RPC transport
Posted by "Ivan Zuzak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Zuzak updated SHINDIG-1196:
--------------------------------
Attachment: wpm-transport-multiline-string-bug.patch
Patch for the multi-line string split bug.
> Wrong multi-line splitting of long string constant in wpm RPC transport
> -----------------------------------------------------------------------
>
> Key: SHINDIG-1196
> URL: https://issues.apache.org/jira/browse/SHINDIG-1196
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Ivan Zuzak
> Priority: Minor
> Attachments: wpm-transport-multiline-string-bug.patch
>
>
> In features/src/main/javascript/features/rpc/wpm.transport.js a long string is split between two lines using string concatenation like so:
> gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
> + ", cannot send cross-domain message");
> However, this is wrong and produces the following output in nightly Chromium and Firefox:
> ""No relay set (used as window.postMessage targetOrigin)NaN"
> The proper way to concatenate strings is to use a single "+" character like this:
> gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
> ", cannot send cross-domain message");
> which produces the correct output. I've attached a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1196) Wrong multi-line splitting of long
string constant in wpm RPC transport
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1196.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA4
Thanks!
> Wrong multi-line splitting of long string constant in wpm RPC transport
> -----------------------------------------------------------------------
>
> Key: SHINDIG-1196
> URL: https://issues.apache.org/jira/browse/SHINDIG-1196
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Reporter: Ivan Zuzak
> Priority: Minor
> Fix For: 1.1-BETA4
>
> Attachments: wpm-transport-multiline-string-bug.patch
>
>
> In features/src/main/javascript/features/rpc/wpm.transport.js a long string is split between two lines using string concatenation like so:
> gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
> + ", cannot send cross-domain message");
> However, this is wrong and produces the following output in nightly Chromium and Firefox:
> ""No relay set (used as window.postMessage targetOrigin)NaN"
> The proper way to concatenate strings is to use a single "+" character like this:
> gadgets.error("No relay set (used as window.postMessage targetOrigin)" +
> ", cannot send cross-domain message");
> which produces the correct output. I've attached a patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.