You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Pankaj Kumar (JIRA)" <ji...@apache.org> on 2016/01/21 14:23:39 UTC

[jira] [Commented] (HBASE-15109) Region server failed to start when "fs.hdfs.impl.disable.cache" is set to true

    [ https://issues.apache.org/jira/browse/HBASE-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110566#comment-15110566 ] 

Pankaj Kumar commented on HBASE-15109:
--------------------------------------

Two approach can be adopted here when fs.hdfs.impl.disable.cache is set true,
- During installation, skip suppressing HDFS shutdownhook.
	{code}
	boolean disabledFsCache = fs.getConf().getBoolean("fs.hdfs.impl.disable.cache", false);
        if (!disabledFsCache && !fsShutdownHooks.containsKey(hdfsClientFinalizer) &&
            !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) {
          throw new RuntimeException("Failed suppression of fs shutdown hook: " +
            hdfsClientFinalizer);
        }
	{code}

       OR

- we can disable shutdownhook feature completely by having check in HRegionServer when fs.hdfs.impl.disable.cache is set true ,
	{code}
	boolean disabledFsCache = fs.getConf().getBoolean("fs.hdfs.impl.disable.cache", false);
	if(!disabledFsCache){
            ShutdownHook.install(conf, fs, this, Thread.currentThread());
	}
	{code}


> Region server failed to start when "fs.hdfs.impl.disable.cache" is set to true
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-15109
>                 URL: https://issues.apache.org/jira/browse/HBASE-15109
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 1.0.0
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Critical
>
> Region server failed to start during installing ShutdownHook when "fs.hdfs.impl.disable.cache" is set to true in core-site.xml at HBase side.
> {code}
> 2016-01-14 15:30:56,358 | FATAL | regionserver/ds2/192.168.152.230:21302 | ABORTING region server ds2,21302,1452756654352: Unhandled: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6 | org.apache.hadoop.hbase.regionserver.HRegionServer.abort(HRegionServer.java:2054)
> java.lang.RuntimeException: Failed suppression of fs shutdown hook: org.apache.hadoop.fs.FileSystem$Cache$ClientFinalizer@571527d6
> at org.apache.hadoop.hbase.regionserver.ShutdownHook.suppressHdfsShutdownHook(ShutdownHook.java:204)
> at org.apache.hadoop.hbase.regionserver.ShutdownHook.install(ShutdownHook.java:84)
> at org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:893)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> During installation, first time it will try to suppress the HDFS shutdownhook by removing the hdfsclientfinalizer from HDFS. Since fs.hdfs.impl.disable.cache is enabled, so removal will be unsuccessful from HDFS  (FS is not cached) and RuntimeException will be thrown with "Failed suppression of fs shutdown hook" message.
> In ShutdownHook,
> {code}
> if (!fsShutdownHooks.containsKey(hdfsClientFinalizer) &&
> !ShutdownHookManager.deleteShutdownHook(hdfsClientFinalizer)) {
> throw new RuntimeException("Failed suppression of fs shutdown hook: " +
> hdfsClientFinalizer);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)