You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/16 07:56:14 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39602: [SPARK-42021][CONNECT][PYTHON] Make `createDataFrame` support `array.array`
zhengruifeng opened a new pull request, #39602:
URL: https://github.com/apache/spark/pull/39602
### What changes were proposed in this pull request?
Make `createDataFrame` support `array.array`
### Why are the changes needed?
for parity
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
enabled UT and added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39602: [SPARK-42021][CONNECT][PYTHON] Make `createDataFrame` support `array.array`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39602:
URL: https://github.com/apache/spark/pull/39602#issuecomment-1384688960
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39602: [SPARK-42021][CONNECT][PYTHON] Make `createDataFrame` support `array.array`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39602:
URL: https://github.com/apache/spark/pull/39602#discussion_r1070927723
##########
python/pyspark/sql/connect/session.py:
##########
@@ -299,9 +296,9 @@ def createDataFrame(
# we need to convert it to [[1], [2], [3]] to be able to infer schema.
_data = [[d] for d in _data]
- try:
- _inferred_schema = self._inferSchemaFromList(_data, _cols)
- except Exception:
+ _inferred_schema = self._inferSchemaFromList(_data, _cols)
Review Comment:
changes in this file is to make the error thrown in `test_array_types`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39602: [SPARK-42021][CONNECT][PYTHON] Make `createDataFrame` support `array.array`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39602:
URL: https://github.com/apache/spark/pull/39602#discussion_r1070927723
##########
python/pyspark/sql/connect/session.py:
##########
@@ -299,9 +296,9 @@ def createDataFrame(
# we need to convert it to [[1], [2], [3]] to be able to infer schema.
_data = [[d] for d in _data]
- try:
- _inferred_schema = self._inferSchemaFromList(_data, _cols)
- except Exception:
+ _inferred_schema = self._inferSchemaFromList(_data, _cols)
Review Comment:
changes in this file is to match the error thrown in `test_array_types`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39602: [SPARK-42021][CONNECT][PYTHON] Make `createDataFrame` support `array.array`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39602: [SPARK-42021][CONNECT][PYTHON] Make `createDataFrame` support `array.array`
URL: https://github.com/apache/spark/pull/39602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org