[GitHub] [incubator-livy] ayushtkn commented on a diff in pull request #394: [LIVY-593] Add flags to support hadoop, spark and scala version specific builds

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #394:
URL: https://github.com/apache/incubator-livy/pull/394#discussion_r1147898935


##########
README.md:
##########
@@ -88,3 +88,13 @@ between different Spark versions.
 
 The Livy package itself does not contain a Spark distribution. It will work with any supported
 version of Spark without needing to rebuild.
+
+### Build Profiles
+
+| Flag        | Purpose                                                            |
+|-------------|--------------------------------------------------------------------|
+| -Phadoop2   | Choose Hadoop2 based build dependencies (default configuration)    |
+| -Pspark2    | Choose Spark 2.x based build dependencies (default configuration)  |
+| -Pscala-2.11 | Choose Scala 2.11 based build dependencies (default configuration) |        
+| -Pscala-2.12 | Choose scala 2.12 based build dependencies                         |
+| -Pspark3 | Choose Spark 3.x based build dependencies |                                                

Review Comment:
   This sounds tough to do and very hard coded, Do we have an option like -Dhadoop.version=3.3.5 and have a way to provide them at runtime, if we can do that 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org