[GitHub] [spark] sunchao commented on a change in pull request #33803: [SPARK-36556][SQL] Add DSV2 filters

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #33803:
URL: https://github.com/apache/spark/pull/33803#discussion_r699485306



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/filter/EqualNullSafe.java
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.connector.expressions.filter;
+
+import org.apache.spark.annotation.Evolving;
+import org.apache.spark.sql.connector.expressions.Expression;
+import org.apache.spark.sql.connector.expressions.Literal;
+
+/**
+ * Performs equality comparison, similar to [[EqualTo]]. However, this differs from [[EqualTo]]
+ * in that it returns `true` (rather than NULL) if both inputs are NULL, and `false`
+ * (rather than NULL) if one of the input is NULL and the other is not NULL.
+ *
+ * @since 3.3.0
+ */
+@Evolving
+public final class EqualNullSafe<T> extends Filter {
+  private final Expression column;
+  private final Literal<T> value;
+
+  public EqualNullSafe(Expression column, Literal<T> value) {
+    this.column = column;
+    this.value = value;
+  }
+
+  public Expression column() { return column; }

Review comment:
       Currently no, but we think it can be an optimization in future, by allowing V2 functions to appear in the filters. As mentioned earlier, another use case is function pushdown. For example, I've also being told that in Druid, some functions related to timestamp can be efficiently evaluated on the data source level.
   
   IMO it's better to leave more room in the API design so it can be extended for more use cases such as the above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org