You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2016/04/28 00:01:17 UTC
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/300
CB-10096: Upgrading to Gradle Plugin 2.1.0
This is a minor change, but I need people running stable to make sure it works. @riknoll Can you take a quick look?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-android InstantRun
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit 6b7dce0cfd381e75cf4afd8256a502b2bf8d328e
Author: Joe Bowser <bo...@apache.org>
Date: 2016-04-27T22:00:18Z
CB-10096: Upgrading to Gradle Plugin 2.1.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215511375
I built/ran mobilespec with and without crosswalk and I didn't encounter any issues. One weird thing that did happen was that I wasn't able to increase the size of the gradle daemon heap from within gradle.properties. Gradle's build output was advising me to edit my gradle.properties file so that I could use the new dexing-in-process feature, but I couldn't get that to work. Passing it as an argument worked:
```
cordova build android -- --gradleArg=-Dorg.gradle.jvmargs=-Xmx2048M
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-216315269
@riknoll It should skip HTML and JS changes. If not, this isn't really worth doing other than correctness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215245487
## [Current coverage][cc-pull] is **100%**
> Merging [#300][cc-pull] into [master][cc-base-branch] will not change coverage
```diff
@@ master #300 diff @@
========================================
Files 11 11
Lines 1707 1707
Methods 207 207
Messages 0 0
Branches 169 169
========================================
Hits 1707 1707
Misses 0 0
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by 9378d3c
[cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/300?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-219804680
OK, I pushed this in. Closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-219803203
@infil00p Let's get this in - I get a prompt in Android Studio without this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215272746
Sure, I'll try it out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215524649
I tried it out a bit just now (without crosswalk). Java code changes refreshed fine for me. The webview gets restarted of course, but my java changes were reflected as expected and the app did not get restarted. Changes to js, html, etc. were less speedy (app gets killed/restarted). I was just building mobilespec so I didn't really see any drastic improvements in that scenario since it already builds pretty quickly. Are there any specific scenarios you want me to try out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-215512407
@riknoll Did you test Instant Run on Android Studio? I don't expect this to work with Crosswalk. We need help from them getting Crosswalk to work with the new Gradle stuff
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org