You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/08 09:11:32 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5691: arm: Move setjmp to common place
no1wudi opened a new pull request #5691:
URL: https://github.com/apache/incubator-nuttx/pull/5691
## Summary
Since some Cortex A core supports thumb mode also,
thus they can share same implementation.
## Impact
None
## Testing
sabre-6quad with ostest (setjmp test),
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5691: arm: Move setjmp to common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5691:
URL: https://github.com/apache/incubator-nuttx/pull/5691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5691: arm: Move setjmp to common place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5691:
URL: https://github.com/apache/incubator-nuttx/pull/5691#discussion_r821586359
##########
File path: arch/arm/Kconfig
##########
@@ -82,6 +82,7 @@ config ARCH_CHIP_IMX6
select ARCH_CORTEXA9
select ARM_THUMB
select ARMV7A_HAVE_L2CC_PL310
+ select ARCH_HAVE_SETJMP if ARCH_TOOLCHAIN_GNU
Review comment:
should we move the selection to ARCH_ARM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5691: arm: Move setjmp to common place
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5691:
URL: https://github.com/apache/incubator-nuttx/pull/5691#discussion_r821608712
##########
File path: arch/arm/Kconfig
##########
@@ -82,6 +82,7 @@ config ARCH_CHIP_IMX6
select ARCH_CORTEXA9
select ARM_THUMB
select ARMV7A_HAVE_L2CC_PL310
+ select ARCH_HAVE_SETJMP if ARCH_TOOLCHAIN_GNU
Review comment:
We can move it to ARCH_ARM after arm version added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org