You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "risdenk (via GitHub)" <gi...@apache.org> on 2023/04/01 13:35:28 UTC

[GitHub] [solr] risdenk commented on pull request #1513: SOLR-15703: replace all SolrException.log usage in Solr to just call log.error(...) directly

risdenk commented on PR #1513:
URL: https://github.com/apache/solr/pull/1513#issuecomment-1492972186

   There are a bunch of outstanding no error message logs as well:
   
   ```
   # git grep -F 'log.error(""'
   solr/core/src/java/org/apache/solr/cloud/Overseer.java:          log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/OverseerTaskProcessor.java:        log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java:        log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/ZkController.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/ZkController.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/ZkController.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/ZkController.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/ZkController.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/ZkController.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/cloud/ZkController.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/core/ZkContainer.java:        log.error("", e);
   solr/core/src/java/org/apache/solr/core/ZkContainer.java:        log.error("", e);
   solr/core/src/java/org/apache/solr/core/ZkContainer.java:              log.error("", e);
   solr/core/src/java/org/apache/solr/core/ZkContainer.java:              log.error("", e);
   solr/core/src/java/org/apache/solr/core/ZkContainer.java:                log.error("", e1);
   solr/core/src/java/org/apache/solr/core/ZkContainer.java:                log.error("", e1);
   solr/core/src/java/org/apache/solr/core/ZkContainer.java:              log.error("", e);
   solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java:      log.error("", e);
   solr/core/src/java/org/apache/solr/schema/ZkIndexSchemaReader.java:        log.error("", e);
   solr/core/src/test/org/apache/solr/cloud/TestStressInPlaceUpdates.java:                log.error("", e);
   solr/core/src/test/org/apache/solr/cloud/TestStressInPlaceUpdates.java:                log.error("", e);
   solr/core/src/test/org/apache/solr/search/TestReloadDeadlock.java:                log.error("", e);
   solr/core/src/test/org/apache/solr/search/TestStressReorder.java:                log.error("", e);
   solr/core/src/test/org/apache/solr/search/TestStressReorder.java:                log.error("", e);
   solr/core/src/test/org/apache/solr/search/TestStressUserVersions.java:                log.error("", e);
   solr/core/src/test/org/apache/solr/search/TestStressUserVersions.java:                log.error("", e);
   solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ConnectionManager.java:                    log.error("", e);
   solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java:        log.error("", e);
   solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java:                log.error("", e);
   solr/solrj/src/java/org/apache/solr/common/util/ObjectReleaseTracker.java:          log.error("", t);
   solr/solrj/src/java/org/apache/solr/common/util/ObjectReleaseTracker.java:          log.error("", t);
   ```
   
   I also like @dsmiley don't understand why. I tried to change the SolrException.log("") to have some meaningful error message associated with it. I did not change any of the above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org