You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "williamhyun (via GitHub)" <gi...@apache.org> on 2025/06/11 20:49:05 UTC

[PR] Fix: Resolve telemetry quickstart example for 1.0 release [polaris]

williamhyun opened a new pull request, #1873:
URL: https://github.com/apache/polaris/pull/1873

   Fixes: #1871 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix telemetry quickstart example for 1.0 release [polaris]

Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on PR #1873:
URL: https://github.com/apache/polaris/pull/1873#issuecomment-2964415823

   LGTM except for one minor issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix telemetry quickstart example for 1.0 release [polaris]

Posted by "HonahX (via GitHub)" <gi...@apache.org>.
HonahX commented on code in PR #1873:
URL: https://github.com/apache/polaris/pull/1873#discussion_r2141189220


##########
getting-started/telemetry/README.md:
##########
@@ -50,10 +52,10 @@ This example requires `jq` to be installed on your machine.
    the `Polairs-Request-Id` header; you should see it in all logs and traces:
 
     ```shell
-    curl -v http://127.0.0.1:8181/api/management/v1/principal-roles \
+    curl -v http://localhost:8181/api/management/v1/principal-roles \
       -H "Authorization: Bearer $POLARIS_TOKEN" \
       -H "Polaris-Request-Id: 1234"
-    curl -v http://127.0.0.1:8181/api/catalog/v1/config?warehouse=polaris_demo \
+    curl -v 'http://localhost.0.0.1:8181/api/catalog/v1/config?warehouse=quickstart_catalog' \

Review Comment:
   ```suggestion
       curl -v 'http://localhost:8181/api/catalog/v1/config?warehouse=quickstart_catalog' \
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix telemetry quickstart example for 1.0 release [polaris]

Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on code in PR #1873:
URL: https://github.com/apache/polaris/pull/1873#discussion_r2141180987


##########
LICENSE:
##########
@@ -220,8 +220,6 @@ This product includes code from Apache Iceberg.
 * integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java
 * service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java
 * service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java
-* plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java
-* plugins/spark/v3.5/spark/src/test/java/org/apache/polaris/spark/PolarisInMemoryCatalog.java

Review Comment:
   This needs a rebase to the current main.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix telemetry quickstart example for 1.0 release [polaris]

Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #1873:
URL: https://github.com/apache/polaris/pull/1873#discussion_r2141170805


##########
LICENSE:
##########
@@ -220,8 +220,6 @@ This product includes code from Apache Iceberg.
 * integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationTest.java
 * service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java
 * service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHandlerUtils.java
-* plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java
-* plugins/spark/v3.5/spark/src/test/java/org/apache/polaris/spark/PolarisInMemoryCatalog.java

Review Comment:
   is this intened ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix telemetry quickstart example for 1.0 release [polaris]

Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on PR #1873:
URL: https://github.com/apache/polaris/pull/1873#issuecomment-2964424477

   Thank you @singhpk234, @flyrain, and @HonahX for the reviews!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix telemetry quickstart example for 1.0 release [polaris]

Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #1873:
URL: https://github.com/apache/polaris/pull/1873


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org