You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2025/06/17 07:11:51 UTC
[PR] GH-46831: [R] Update SystemRequirements with required CMake >= 3.25 [arrow]
raulcd opened a new pull request, #46834:
URL: https://github.com/apache/arrow/pull/46834
### Rationale for this change
Current system requirements is outdated and was not updated to match the CMake update on:
- https://github.com/apache/arrow/pull/44989
### What changes are included in this PR?
Update the system requirements to CMake >= 3.25.
### Are these changes tested?
No, this is only documentation.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46834:
URL: https://github.com/apache/arrow/pull/46834#discussion_r2158384064
##########
ci/conan/all/conanfile.py:
##########
@@ -268,7 +268,9 @@ def validate(self):
raise ConanInvalidConfiguration("arrow:parquet requires arrow:with_thrift")
def build_requirements(self):
- if Version(self.version) >= "13.0.0":
+ if Version(self.version) >= "20.0.0":
+ self.tool_requires("cmake/[>=3.25 <4]")
+ else:
Review Comment:
Because it was added after https://github.com/apache/arrow/pull/46758 .
##########
ci/conan/all/conanfile.py:
##########
@@ -268,7 +268,9 @@ def validate(self):
raise ConanInvalidConfiguration("arrow:parquet requires arrow:with_thrift")
def build_requirements(self):
- if Version(self.version) >= "13.0.0":
+ if Version(self.version) >= "20.0.0":
+ self.tool_requires("cmake/[>=3.25 <4]")
+ else:
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #46834:
URL: https://github.com/apache/arrow/pull/46834#discussion_r2158335237
##########
ci/conan/all/test_package/CMakeLists.txt:
##########
@@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
-cmake_minimum_required(VERSION 3.15)
+cmake_minimum_required(VERSION 3.25)
Review Comment:
Ditto.
##########
ci/conan/all/conanfile.py:
##########
@@ -268,7 +268,9 @@ def validate(self):
raise ConanInvalidConfiguration("arrow:parquet requires arrow:with_thrift")
def build_requirements(self):
- if Version(self.version) >= "13.0.0":
+ if Version(self.version) >= "20.0.0":
+ self.tool_requires("cmake/[>=3.25 <4]")
+ else:
Review Comment:
Could you keep `ci/conan/**` files untouched?
`ci/conan/**` files are synchronized by `ci/conan/merge_upstream.sh` from upstream. If we change `ci/conan/**` in apache/arrow, the merge script may report many conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46834:
URL: https://github.com/apache/arrow/pull/46834#discussion_r2158380217
##########
ci/conan/all/test_package/CMakeLists.txt:
##########
@@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
-cmake_minimum_required(VERSION 3.15)
+cmake_minimum_required(VERSION 3.25)
Review Comment:
```suggestion
cmake_minimum_required(VERSION 3.15)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46834:
URL: https://github.com/apache/arrow/pull/46834#discussion_r2158387062
##########
ci/conan/all/conanfile.py:
##########
@@ -268,7 +268,9 @@ def validate(self):
raise ConanInvalidConfiguration("arrow:parquet requires arrow:with_thrift")
def build_requirements(self):
- if Version(self.version) >= "13.0.0":
+ if Version(self.version) >= "20.0.0":
+ self.tool_requires("cmake/[>=3.25 <4]")
+ else:
Review Comment:
ok, I'll revert that and we can push it on a follow up PR. Thanks @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46834:
URL: https://github.com/apache/arrow/pull/46834#discussion_r2158376877
##########
ci/conan/all/conanfile.py:
##########
@@ -268,7 +268,9 @@ def validate(self):
raise ConanInvalidConfiguration("arrow:parquet requires arrow:with_thrift")
def build_requirements(self):
- if Version(self.version) >= "13.0.0":
+ if Version(self.version) >= "20.0.0":
+ self.tool_requires("cmake/[>=3.25 <4]")
+ else:
Review Comment:
Is there a reason we haven't kept them in sync with upstream then?
https://github.com/conan-io/conan-center-index/blob/7e4cf19b663a2cfa7e9a57b8260ba003e046a46c/recipes/arrow/all/conanfile.py#L256-L260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [R] Update SystemRequirements with required CMake >= 3.25 and docs/building.rst [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #46834:
URL: https://github.com/apache/arrow/pull/46834#issuecomment-2990225870
@github-actions crossbow submit -g conan example-cpp-minimal-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46834:
URL: https://github.com/apache/arrow/pull/46834#discussion_r2158379080
##########
ci/conan/all/conanfile.py:
##########
@@ -268,7 +268,9 @@ def validate(self):
raise ConanInvalidConfiguration("arrow:parquet requires arrow:with_thrift")
def build_requirements(self):
- if Version(self.version) >= "13.0.0":
+ if Version(self.version) >= "20.0.0":
+ self.tool_requires("cmake/[>=3.25 <4]")
+ else:
Review Comment:
ok, this is from a commit from 3 days ago, should we use the script on a different PR to update it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #46834:
URL: https://github.com/apache/arrow/pull/46834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [R] Update SystemRequirements with required CMake >= 3.25 and docs/building.rst [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #46834:
URL: https://github.com/apache/arrow/pull/46834#issuecomment-2980656811
> Let's also update the docs: https://github.com/apache/arrow/blob/main/docs/source/developers/cpp/building.rst?plain=1#L454
Good point @assignUser. Also, here are a few other places we refer to 3.16:
https://github.com/apache/arrow/blob/639201bfa412db26ce45e73851432018af6c945e/cpp/cmake_modules/ThirdpartyToolchain.cmake#L5305-L5314
https://github.com/apache/arrow/blob/639201bfa412db26ce45e73851432018af6c945e/ci/conan/all/conanfile.py#L270-L272
https://github.com/apache/arrow/blob/main/cpp/examples/minimal_build/CMakeLists.txt#L18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + conan + minor CMake references) [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46834:
URL: https://github.com/apache/arrow/pull/46834#issuecomment-2990231935
Revision: f0310e6d82b13e8a126439490d78f736c71f3536
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5c4d9c0865](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5c4d9c0865)
|Task|Status|
|----|------|
|conan-maximum|[](https://github.com/ursacomputing/crossbow/actions/runs/15774522996/job/44465846347)|
|conan-minimum|[](https://github.com/ursacomputing/crossbow/actions/runs/15774523350/job/44465847316)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/15774523064/job/44465846537)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/15774522942/job/44465846333)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46834:
URL: https://github.com/apache/arrow/pull/46834#issuecomment-2992816493
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6822857775bafc765b9e75a09e0b7470ce1a957b.
There were 119 benchmark results with an error:
- Commit Run on `arm64-t4g-2xlarge-linux` at [2025-06-20 13:00:24Z](https://conbench.ursa.dev/compare/runs/17b41a9f54494623837def44a01ef69a...fcd689ff0e604fca90870d7b29583a43/)
- [`tpch` (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1](https://conbench.ursa.dev/benchmark-results/068556c6158374638000d6cc03775e92)
- [`tpch` (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1](https://conbench.ursa.dev/benchmark-results/068556d173e977b080004a8d19bf81d3)
- and 117 more (see the report linked below)
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/44507142681) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46831: [R] Update SystemRequirements with required CMake >= 3.25 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46834:
URL: https://github.com/apache/arrow/pull/46834#issuecomment-2979204485
:warning: GitHub issue #46831 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org