You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/12/03 22:59:42 UTC
[GitHub] sunjincheng121 commented on a change in pull request #6918:
[FLINK-10543][table] Leverage efficient timer deletion in relational
operators
sunjincheng121 commented on a change in pull request #6918: [FLINK-10543][table] Leverage efficient timer deletion in relational operators
URL: https://github.com/apache/flink/pull/6918#discussion_r238465825
##########
File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowJoin.scala
##########
@@ -18,7 +18,7 @@
package org.apache.flink.table.runtime.join
import org.apache.flink.api.common.functions.FlatJoinFunction
-import org.apache.flink.api.common.state.{MapState, MapStateDescriptor, ValueState, ValueStateDescriptor}
+import org.apache.flink.api.common.state._
Review comment:
IMO. `{State, MapState, MapStateDescriptor, ValueState, ValueStateDescriptor}` is better,What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services