You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/08 13:34:10 UTC

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus

gaoran10 commented on code in PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#discussion_r892377576


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -231,12 +230,6 @@ private static void generateBrokerBasicMetrics(PulsarService pulsar, SimpleTextO
                 clusterName, Collector.Type.GAUGE, stream);
         }
 
-        if (pulsar.getConfiguration().isExposeManagedCursorMetricsInPrometheus()) {

Review Comment:
   If using the Prometheus class to collect metrics, the metrics data will record automatically, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org