You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by "Runkang He (Jira)" <ji...@apache.org> on 2023/08/13 09:49:00 UTC
[jira] [Created] (CALCITE-5923) Some test cases in `SqlOperatorTest` violates the test fixture's design principle
Runkang He created CALCITE-5923:
-----------------------------------
Summary: Some test cases in `SqlOperatorTest` violates the test fixture's design principle
Key: CALCITE-5923
URL: https://issues.apache.org/jira/browse/CALCITE-5923
Project: Calcite
Issue Type: Bug
Components: core
Affects Versions: 1.35.0
Reporter: Runkang He
There are some test cases in `SqlOperatorTest` directly use the `SqlOperatorFixtureImpl.DEFAULT` to get the `SqlOperatorFixture`, including `SqlOperatorTest.testCast` and many other test cases related with `CAST` operator.
This violates the design principle introduced by CALCITE-4885, which we should alway use `SqlOperatorTest.fixture()` to get the `SqlOperatorFixture`. This principle allows us to override`fixture()` method in subclasses to run tests in a different environment.
So I think we should fix these related test cases to keep consistent with the principle.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)