You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by GitBox <gi...@apache.org> on 2021/04/28 05:45:55 UTC
[GitHub] [openwebbeans-meecrowave] bmarwell opened a new pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.
bmarwell opened a new pull request #15:
URL: https://github.com/apache/openwebbeans-meecrowave/pull/15
Jira: https://issues.apache.org/jira/browse/MEECROWAVE-289
[x] signed the CLA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans-meecrowave] rmannibucau commented on a change in pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #15:
URL: https://github.com/apache/openwebbeans-meecrowave/pull/15#discussion_r621844841
##########
File path: meecrowave-specs-api/pom.xml
##########
@@ -206,6 +206,126 @@
</transformers>
</configuration>
</execution>
+ <execution>
+ <id>jakarta</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadedArtifactAttached>true</shadedArtifactAttached>
+ <shadedClassifierName>jakarta</shadedClassifierName>
+ <createDependencyReducedPom>false</createDependencyReducedPom>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ </transformer>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
Review comment:
guess cxf and log4j config is not needed here?
Also relocation patterns are too complete (persistence, validation etc are not provided)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwebbeans-meecrowave] bmarwell commented on a change in pull request #15: [MEECROWAVE-289] add jakarta artifact for mw-specs-api.
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #15:
URL: https://github.com/apache/openwebbeans-meecrowave/pull/15#discussion_r626268261
##########
File path: meecrowave-specs-api/pom.xml
##########
@@ -206,6 +206,126 @@
</transformers>
</configuration>
</execution>
+ <execution>
+ <id>jakarta</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadedArtifactAttached>true</shadedArtifactAttached>
+ <shadedClassifierName>jakarta</shadedClassifierName>
+ <createDependencyReducedPom>false</createDependencyReducedPom>
+ <transformers>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
+ <transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ </transformer>
+ <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
Review comment:
Thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org