You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2020/08/24 14:33:15 UTC
[GitHub] [incubator-pegasus] neverchanje opened a new pull request #585: fix(script): operation return before the cluster balance when using pegasus_rolling_update.sh
neverchanje opened a new pull request #585:
URL: https://github.com/apache/incubator-pegasus/pull/585
### What problem does this PR solve? <!--add issue link with summary if exists-->
The script return when get the `op_count=0` at `rebalance stage` when using the `pegasus_rolling_update.sh ` to update cluster `all` job(meta, replica, collector). However, `op_count` may have not be updated. This pr add the `double-check`which will wait 30s and check again when `op_count=0`. if it still zero, the script judge the cluster is balanced.
Beside, this pr split the `rebalance process` to `pegasus_rebalance_cluster.sh` for `pegasus_rolling_update.sh ` and `pegasus_add_node_list.sh `, user can also uses it directly.
### Note
`pegasus_rolling_update.sh ` one job(replica server) won't execute `rebalance` cluster, you need use `pegasus_rebalance_cluster.sh` to rebalance it after only rolling replica server
### What is changed and how it works?
* Split the `rebalance process` to `pegasus_rebalance_cluster`
* Double check after wait 30s when `op_count=0`
### Check List <!--REMOVE the items that are not applicable-->
- Manual test (add detailed scripts or steps below)
(1) deploy the cluster with minos
(2) execute pegasus_rebalance_cluster.sh/pegasus_rolling_update.sh/pegasus_add_node_list.sh
Related changes
- Need to cherry-pick to the release branch
- Need to be included in the release note
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje merged pull request #585: fix(script): operation return before the cluster balance when using pegasus_rolling_update.sh
Posted by GitBox <gi...@apache.org>.
neverchanje merged pull request #585:
URL: https://github.com/apache/incubator-pegasus/pull/585
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org