You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "HsbcJone (via GitHub)" <gi...@apache.org> on 2023/05/04 14:06:54 UTC

[GitHub] [incubator-seatunnel] HsbcJone commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits

HsbcJone commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185073734


##########
docs/en/connector-v2/source/Http.md:
##########
@@ -17,23 +17,24 @@ Used to read data from Http.
 
 ## Options
 
-|            name             |  type  | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url                         | String | Yes      | -             |
-| schema                      | Config | No       | -             |
-| schema.fields               | Config | No       | -             |
-| json_field                  | Config | No       | -             |
-| content_json                | String | No       | -             |
-| format                      | String | No       | json          |
-| method                      | String | No       | get           |
-| headers                     | Map    | No       | -             |
-| params                      | Map    | No       | -             |
-| body                        | String | No       | -             |
-| poll_interval_ms            | int    | No       | -             |
-| retry                       | int    | No       | -             |
-| retry_backoff_multiplier_ms | int    | No       | 100           |
-| retry_backoff_max_ms        | int    | No       | 10000         |
-| common-options              |        | No       | -             |
+|            name             |  type   | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url                         | String  | Yes      | -             |
+| schema                      | Config  | No       | -             |
+| schema.fields               | Config  | No       | -             |
+| json_field                  | Config  | No       | -             |
+| content_json                | String  | No       | -             |
+| format                      | String  | No       | json          |
+| method                      | String  | No       | get           |
+| headers                     | Map     | No       | -             |
+| params                      | Map     | No       | -             |
+| body                        | String  | No       | -             |
+| poll_interval_ms            | int     | No       | -             |
+| retry                       | int     | No       | -             |
+| retry_backoff_multiplier_ms | int     | No       | 100           |
+| retry_backoff_max_ms        | int     | No       | 10000         |
+| common-options              |         | No       | -             |
+| enableMultiLines            | boolean | No       | false         |

Review Comment:
   > Is this setting required for connectors other than http?
   
   Yes, I think this configuration is universal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org